138 fix the metric for dataless formations #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizruk
reviewed
Feb 21, 2024
| countDataless :: (MonadState Metrics m) => [Binding] -> m () | ||
| countDataless bindings = do | ||
| let countDeltas = count (\case DeltaBinding _ -> True; _ -> False) | ||
| deltas = countDeltas (bindings <> concatMap (\case AlphaBinding _ (Formation bindings') -> bindings'; _ -> []) bindings) |
There was a problem hiding this comment.
Seems like a very bad case-oneliner. Why not introduce a helper properly?
fizruk
reviewed
Feb 21, 2024
| count :: (a -> Bool) -> [a] -> Int | ||
| count x = length . filter x | ||
|
|
||
| countDataless :: (MonadState Metrics m) => [Binding] -> m () |
There was a problem hiding this comment.
This function requires documentation and a doctest.
deemp
force-pushed
the
138-fix-the-metric-for-dataless-formations
branch
from
4926ee0 to
2fa396e
Compare
fizruk
reviewed
Feb 21, 2024
| countDataless :: (Num a) => [Binding] -> a | ||
| countDataless bindings = | ||
| let countDeltas = count (\case DeltaBinding _ -> True; _ -> False) | ||
| nestedBindings = concatMap (\case AlphaBinding _ (Formation bindings') -> bindings'; _ -> []) bindings |
There was a problem hiding this comment.
This one-line case is still terrible :)
There was a problem hiding this comment.
I see no issues with it as long as I have only two cases, where the second one is trivial. Please, feel free to suggest changes.
There was a problem hiding this comment.
I think it makes sense to factor out this case into a separate named helper function and use indentation, not ; for the cases. This is not critical, just a style thing.
fizruk
approved these changes
Feb 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138
PR-Codex overview
This PR enhances the
eo-phi-normalizerby improving metrics calculation and adding a new function for counting dataless formations.Detailed summary
datalessmetric values inmetrics.yamlcountDatalessto count dataless formations in bindingsCollect.hsto utilize the new function