Add better autocomplete patch to playground #498
Conversation
| +const edgeDirectives = new Set(['fold', 'recurse', 'optional', 'transform']) | ||
| +const propertyDirectives = new Set(['filter', 'tag', 'output', 'transform']) |
There was a problem hiding this comment.
Will this prevent us from doing something like:
{
Root {
edge @fold @transform(op: "count") @filter(op: ">", value: ["$zero"]) @output @tag {
# ... other stuff
}
# ... other stuff
}
}There was a problem hiding this comment.
It won’t prevent it, but we will not autocomplete properties after transform yet, that seems like it will be much more involved to add, although it can be explored.
There was a problem hiding this comment.
if a user started typing @filter after a @transform on an edge, will it continue the completion from there?
Imagine they are here:
{ Root { edge @fold @transform(op: "count") @filWill it autocomplete @filter and its arguments?
If yes, that's great and let's merge this. If not, we should maybe add all the possible directives that could appear on edges here instead — it's not great if the autocomplete suggests broken code, but it might be worse if it pretends to not understand completely valid code...
There was a problem hiding this comment.
No it will not, I removed the edge filtering code for now and just left a comment about this case.
With this patch, you can autocomplete directives (with some accuracy based on the preceding field's type) and you can autocomplete fields.