Add external types exposed through public api check for CI #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
Aug 6, 2023
|
|
||
| - name: Check Exported API | ||
| run: | | ||
| cargo install --locked cargo-check-external-types |
There was a problem hiding this comment.
This is going to rebuild on every PR update, which is going to be horrifically slow. The tool's doesn't offer prebuilt binaries, and it's not part of cargo-quickinstall's prebuilt list either.
Almost tempted to not use it over this, to be honest.
What do you think?
There was a problem hiding this comment.
I'm not super upset over it as it takes approximately the same 2 minutes to run the tests. We can also either ask them to offer prebuilt binaries or just build it ourselves on every commit in a different repo similar to what cargo-quickinstall does.
Is there any way we can ask them to add it to cargo-quickinstall?
|
Not sure, check that project's repo? There might be a way to request new
crates to be added.
…On Sat, Aug 5, 2023, 11:08 PM u9g ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yml
<#434 (comment)>:
> + steps:
+ - name: Checkout
+ uses: ***@***.***
+ with:
+ persist-credentials: false
+
+ - name: Install rust
+ uses: ***@***.***
+ with:
+ toolchain: "nightly-2023-05-31"
+
+ - uses: ***@***.***
+
+ - name: Check Exported API
+ run: |
+ cargo install --locked cargo-check-external-types
I'm not super upset over it as it takes approximately the same 2 minutes
to run the tests. We can also either ask them to offer prebuilt binaries or
just build it ourselves on every commit in a different repo similar to what
cargo-quickinstall does.
Is there any way we can ask them to add it to cargo-quickinstall?
—
Reply to this email directly, view it on GitHub
<#434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5MSSYID2WSI7IAFOL53TXT4DDTANCNFSM6AAAAAA3FTEENM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
obi1kenobi
force-pushed
the
main
branch
3 times, most recently
from
15f64a4
to
64ebfd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.