Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added manufactured by Illumina axioms to src/ontology/templates/devices.tsv #1826

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Oct 3, 2024

Edited as CSV in Libre Office. I don't know why ends of other lines changed but am willing to fix it.

cc @cmungall @aclum

edited as CSV in Libre Office. Do not know why ends of other lines changed
@turbomam
Copy link
Contributor Author

turbomam commented Oct 3, 2024

It looks like Libre Office changed some multi-quotation mark strings too

@jamesaoverton
Copy link
Contributor

All those quotation marks are a problem. It's a tab-separated file, so it should use normal English quotation rules, and none of the double-double-quotes that comma-separated files require. In Python the setting we use is QUOTE_NONE, e.g. https://github.com/obi-ontology/obi/blob/master/src/scripts/sort-templates.py#L12, but that still seems to use some double-double-quotes.

I pushed a manual edit that restores the previous quotation marks, so the only change should be the addition of "Illumina" in the manufacturer column.

@jamesaoverton jamesaoverton merged commit 6d9e8a2 into master Oct 3, 2024
1 check passed
@jamesaoverton jamesaoverton deleted the 1824-add-is_manufactured_by-illumina-to-all-illumina-brand-dna-sequencers branch October 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add is_manufactured_by Illumina to all Illumina brand DNA sequencers
2 participants