-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three CRISPR assays #1796
Add three CRISPR assays #1796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sebastian and I looked at this together, and it looks good to me.
src/ontology/templates/assays.tsv
Outdated
@@ -656,6 +656,9 @@ OBI:0003599 single cell T cell receptor repertoire sequencing assay single cell | |||
OBI:0003601 quartz crystal microbalance assay quartz crystal microbalance assay QCM An assay that measures the change in frequency of a quartz crystal resonator resulting from the addition or removal of a small mass of a ligand specifically binding at the surface of the resonator. http://www.ncbi.nlm.nih.gov/pubmed/23504432|https://en.wikipedia.org/wiki/Quartz_crystal_microbalance Randi Vita|Bjoern Peters|Sebastian Duesing subclass assay | |||
OBI:0003604 multiplexed error-robust fluorescence in situ hybridization assay MERFISH A fluorescence in-situ hybridization assay that uses combinatorial FISH labeling with error resistant encoding schemes for highly multiplexed single-molecule imaging. https://en.wikipedia.org/wiki/Fluorescence_in_situ_hybridization#MERFISH Sebastian Duesing Brain Image Library https://github.com/obi-ontology/obi/issues/1724 subclass fluorescence in-situ hybridization assay | |||
OBI:0003605 single molecule fluorescence in situ hybridization smFISH A fluorescence in-situ hybridization assay that detects single RNA molecules in fixed cells, allowing for both the quantification and localization at the single-cell level and single-molecule resolution. https://doi.org/10.21769/BioProtoc.3070 Sebastian Duesing Brain Image Library https://github.com/obi-ontology/obi/issues/1725 subclass fluorescence in-situ hybridization assay | |||
OBI:0003659 in vitro CRISPR screening assay in vitro CRISPR screening assay An assay in which cells expressing a Cas system are infected with a library of guide RNAs with the intent of causing a perturbation at the target of the guide RNAs. Jennifer Jou|Bjoern Peters Jennifer Jou https://github.com/obi-ontology/obi/issues/1784 subclass assay cas mediated mutagenesis assay cell | |||
OBI:0003660 in vitro CRISPR screen using single RNA-Seq in vitro CRISPR screen using single RNA-Seq An in vitro CRISPR screening assay that uses single cell RNA-Seq to detect induced changes in gene expression Jennifer Jou|Bjoern Peters Jennifer Jou https://github.com/obi-ontology/obi/issues/1784 subclass in vitro CRISPR screening assay single-cell RNA sequencing assay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the term name says "single RNA-seq"; I'm not sure if that's accidentally omitting the word "cell" (as in "single cell RNA-seq")?
Also, if it's OK, I'd like to share this pull request with some of our labs working on CRISPR screens to see if they are happy with the terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenjou Good catch—I believe that change was made while Bjoern was editing the template during the OBI call a couple weeks ago. I'll add a commit to change it to "single-cell RNA-Seq". Yes, please feel free to share this PR with the labs.
Relaying some questions from my colleagues following their review:
Edit: one more question I missed.
|
@jenjou Thanks for passing along your colleagues' feedback. Adding a term for "in vitro CRISPR perturbation screen using fluorescence imaging-based reporter gene and flow cytometry" is definitely doable. As for your first three points, my instinct is that those should be standardized, but I don't recall whether or not those phrasings were chosen for a specific reason when Bjoern was filling out the template, so I'll defer to his judgement here. @bpeters42 Can I go ahead and make changes to address the terminology inconsistencies mentioned in Jennifer's comment? If so, do you have a preference on using "in vitro CRISPR perturbation screen assay" vs "in vitro CRISPR perturbation screening assay"? |
Please go ahead and make changes, and I don't have preferences on the label
***@***.*** and her group should decide)
…On Mon, Jul 22, 2024 at 1:04 PM Sebastian Duesing ***@***.***> wrote:
@jenjou <https://github.com/jenjou> Thanks for passing along your
colleagues' feedback. Adding a term for "in vitro CRISPR perturbation
screen using fluorescence imaging-based reporter gene and flow cytometry"
is definitely doable. As for your first three points, my instinct is that
those should be standardized, but I don't recall whether or not those
phrasings were chosen for a specific reason when Bjoern was filling out the
template, so I'll defer to his judgement here.
@bpeters42 <https://github.com/bpeters42> Can I go ahead and make changes
to address the terminology inconsistencies mentioned in Jennifer's comment?
If so, do you have a preference on using "in vitro CRISPR perturbation
*screen* assay" vs "in vitro CRISPR perturbation *screening* assay"?
—
Reply to this email directly, view it on GitHub
<#1796 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJX2IX66NEQTC3PW6WALOTZNVQTZAVCNFSM6AAAAABKTIT4S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTG4ZDCMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Bjoern Peters
Professor
La Jolla Institute for Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters
|
Hello, just wanted to provide some updates as we have had further internal discussion about the terms. I think this is our preferred plan:
Please let me know if that would be reasonable to implement. Thank you! |
Certainly. Does your group have a preference on "screen" vs "screening" or on "perturbation" vs no "perturbation" in the term label? |
Yes, I think our preference is for "screen" and omitting the word "perturbation". So that would correspond to each of the 3 terms like so:
|
Got it, thanks for confirming! I'll make those changes tomorrow. |
Sorry for the back and forth -- but I think OBI:0003668 may not be actively needed on our end. Of course, if OBI thinks it still makes sense to have such a term, then we would have no objection to including it. |
Got it, thanks for letting us know! |
Closes #1784. Adds three CRISPR assay terms using assay template additions created by Bjoern during the 2024-07-08 OBI dev call.