Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three CRISPR assays #1796

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Add three CRISPR assays #1796

merged 5 commits into from
Aug 26, 2024

Conversation

sebastianduesing
Copy link
Contributor

Closes #1784. Adds three CRISPR assay terms using assay template additions created by Bjoern during the 2024-07-08 OBI dev call.

Copy link
Contributor

@jamesaoverton jamesaoverton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebastian and I looked at this together, and it looks good to me.

@@ -656,6 +656,9 @@ OBI:0003599 single cell T cell receptor repertoire sequencing assay single cell
OBI:0003601 quartz crystal microbalance assay quartz crystal microbalance assay QCM An assay that measures the change in frequency of a quartz crystal resonator resulting from the addition or removal of a small mass of a ligand specifically binding at the surface of the resonator. http://www.ncbi.nlm.nih.gov/pubmed/23504432|https://en.wikipedia.org/wiki/Quartz_crystal_microbalance Randi Vita|Bjoern Peters|Sebastian Duesing subclass assay
OBI:0003604 multiplexed error-robust fluorescence in situ hybridization assay MERFISH A fluorescence in-situ hybridization assay that uses combinatorial FISH labeling with error resistant encoding schemes for highly multiplexed single-molecule imaging. https://en.wikipedia.org/wiki/Fluorescence_in_situ_hybridization#MERFISH Sebastian Duesing Brain Image Library https://github.com/obi-ontology/obi/issues/1724 subclass fluorescence in-situ hybridization assay
OBI:0003605 single molecule fluorescence in situ hybridization smFISH A fluorescence in-situ hybridization assay that detects single RNA molecules in fixed cells, allowing for both the quantification and localization at the single-cell level and single-molecule resolution. https://doi.org/10.21769/BioProtoc.3070 Sebastian Duesing Brain Image Library https://github.com/obi-ontology/obi/issues/1725 subclass fluorescence in-situ hybridization assay
OBI:0003659 in vitro CRISPR screening assay in vitro CRISPR screening assay An assay in which cells expressing a Cas system are infected with a library of guide RNAs with the intent of causing a perturbation at the target of the guide RNAs. Jennifer Jou|Bjoern Peters Jennifer Jou https://github.com/obi-ontology/obi/issues/1784 subclass assay cas mediated mutagenesis assay cell
OBI:0003660 in vitro CRISPR screen using single RNA-Seq in vitro CRISPR screen using single RNA-Seq An in vitro CRISPR screening assay that uses single cell RNA-Seq to detect induced changes in gene expression Jennifer Jou|Bjoern Peters Jennifer Jou https://github.com/obi-ontology/obi/issues/1784 subclass in vitro CRISPR screening assay single-cell RNA sequencing assay
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the term name says "single RNA-seq"; I'm not sure if that's accidentally omitting the word "cell" (as in "single cell RNA-seq")?

Also, if it's OK, I'd like to share this pull request with some of our labs working on CRISPR screens to see if they are happy with the terminology.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenjou Good catch—I believe that change was made while Bjoern was editing the template during the OBI call a couple weeks ago. I'll add a commit to change it to "single-cell RNA-Seq". Yes, please feel free to share this PR with the labs.

@jenjou
Copy link

jenjou commented Jul 22, 2024

Relaying some questions from my colleagues following their review:

  • One term mentions "screening" whereas the others are "screen", should this be consistent?
  • One term mentions "perturbation" whereas the others do not (just "CRISPR screen" instead of "CRISPR perturbation screen")
  • For "in vitro CRISPR screening assay", would it make sense to restore the word "proliferation"? This may have been a miscommunication on my part.

Edit: one more question I missed.

@sebastianduesing
Copy link
Contributor Author

@jenjou Thanks for passing along your colleagues' feedback. Adding a term for "in vitro CRISPR perturbation screen using fluorescence imaging-based reporter gene and flow cytometry" is definitely doable. As for your first three points, my instinct is that those should be standardized, but I don't recall whether or not those phrasings were chosen for a specific reason when Bjoern was filling out the template, so I'll defer to his judgement here.

@bpeters42 Can I go ahead and make changes to address the terminology inconsistencies mentioned in Jennifer's comment? If so, do you have a preference on using "in vitro CRISPR perturbation screen assay" vs "in vitro CRISPR perturbation screening assay"?

@bpeters42
Copy link
Contributor

bpeters42 commented Jul 24, 2024 via email

@jenjou
Copy link

jenjou commented Aug 9, 2024

Hello, just wanted to provide some updates as we have had further internal discussion about the terms.

I think this is our preferred plan:

  • Add "in vitro CRISPR screening assay" term, serving as a parent to the other 2 terms.
    • Need to address consistency of screen vs screening, "perturbation" or no "perturbation" in the term
  • Add "in vitro CRISPR screen using single-cell RNA-seq"
    • Need to address consistency of screen vs screening, "perturbation" or no "perturbation" in the term
  • Add "in vitro CRISPR perturbation screen using flow cytometry"
    • Removes "FISH" from the original request to make the term more generic (allows for different methods to cause fluorescence, or sorting by other parameters). Could allow future additions which are more specific for FISH or other methods.
    • Need to address consistency of screen vs screening, "perturbation" or no "perturbation" in the term

Please let me know if that would be reasonable to implement. Thank you!

@sebastianduesing
Copy link
Contributor Author

Certainly. Does your group have a preference on "screen" vs "screening" or on "perturbation" vs no "perturbation" in the term label?

@jenjou
Copy link

jenjou commented Aug 15, 2024

Yes, I think our preference is for "screen" and omitting the word "perturbation". So that would correspond to each of the 3 terms like so:

  • in vitro CRISPR screen assay
  • in vitro CRISPR screen using single-cell RNA-seq
  • in vitro CRISPR screen using flow cytometry

@sebastianduesing
Copy link
Contributor Author

Got it, thanks for confirming! I'll make those changes tomorrow.

@jenjou
Copy link

jenjou commented Aug 19, 2024

Sorry for the back and forth -- but I think OBI:0003668 may not be actively needed on our end. Of course, if OBI thinks it still makes sense to have such a term, then we would have no objection to including it.

@sebastianduesing
Copy link
Contributor Author

Got it, thanks for letting us know!

@jamesaoverton jamesaoverton merged commit 341a306 into master Aug 26, 2024
1 check passed
@jamesaoverton jamesaoverton deleted the 1784_crispr_assays branch August 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR for CRISPR screen assays
4 participants