Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms for fasting/overnight fasting #1763

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Add terms for fasting/overnight fasting #1763

merged 4 commits into from
Mar 18, 2024

Conversation

sebastianduesing
Copy link
Contributor

@sebastianduesing sebastianduesing commented Jan 26, 2024

Closes #494. This one is showing a weirdly big diff for obi-edit like my previous PR, but the ROBOT diff is clean—if there's a reason for the diff looking the way it does, I'll update the PR.

Editing to add: Like the other one, the messy diff is probably an OWL API thing. To discuss on call: fastedness as characteristic.

@sebastianduesing
Copy link
Contributor Author

Updated with changes discussed in OBI dev call on 2024-02-26:

  • Get rid of “as directed by medical professional” clause in definition of fasting
  • Rename "fastedness" to "fasted"
  • Remove "overnight fastedness"
  • Specify that overnight fasting does not actually have to occur overnight, but rather is just a long fast with a duration of 8–12 hours

This PR should be good to go now.

@jamesaoverton jamesaoverton merged commit b58d69e into master Mar 18, 2024
1 check passed
@jamesaoverton jamesaoverton deleted the fasting_494 branch March 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fasted subject / organism
2 participants