Handle pubkey blob in sign call being SSH cert #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timweri
force-pushed
the
bug-fixes
branch
3 times, most recently
from
3c1795d to
8bd4025
Compare
|
Please add a description. |
obelisk
requested changes
Nov 29, 2023
rustica-agent/src/lib.rs
Outdated
| @@ -333,13 +334,27 @@ impl SshAgentHandler for Handler { | |||
|
|
|||
| return Ok(Response::SignResponse { signature }); | |||
| } else if let Signatory::Direct(privkey) = &self.signatory { | |||
| // Extract the pubkey fingerprint from either the SSH pubkey or the SSH cert | |||
There was a problem hiding this comment.
Pull this out of the check and add it to the top of the function. Then we only need to do it once, and when we come back and fix this whole large if statement later it will be easier
obelisk
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the pubkey blob passed into
sign_requestcan either be a PublicKey or a Certificate. Currently, it is always parsed as a PublicKey. So if a certificate is passed in, the parsing fails.This PR makes sure certificate is handled correctly when passed as the pubkey blob into
sign_request.