Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(NetworkConnection::send) #44

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix(NetworkConnection::send) #44

merged 1 commit into from
Nov 11, 2024

Conversation

JadKHaddad
Copy link
Contributor

@JadKHaddad JadKHaddad commented Oct 28, 2024 •
edited
Loading

NetworkConnection::send was trying to send the bytes using write, which - depending on the implementation - might not write the whole buffer to the tcp connection. NetworkConnection::send now uses write_all and flush to make sure, that all the bytes are written to the tcp buffer and flushed.

Issue

#41

Test

  • Esp32-C3
  • Private mosquitto server
  • With TLS using embedded-tls v0.17.0
  • Without TLS

Notes

  • Cargo feature tls was not needed

@JadKHaddad
fix(send): NetworkConnection::send sends bytes via embedded_io_async:…
b5ed04e 
…:Write::write_all and flush

Signed-off-by: Jad K. Haddad <[email protected]>
@lulf lulf merged commit 1b529ef into obabec:main Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulf lulf lulf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JadKHaddad @lulf