Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exception SslHandshakeError #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dencrypt-jacob
Copy link
Contributor

@lganzzzo
I have added a custom exception for SSL handshake errors. The mbedtls error code from mbedtls_ssl_handshake is part of that and can be inspected by the client.

@dencrypt-jacob
Copy link
Contributor Author

Ping @lganzzzo

@lganzzzo
Copy link
Member

Hello @dencrypt-jacob ,

Thanks for the PR, and sorry for the late reply.

This is a good proposition, however, it can't be merged right away as it will cause crash (because of the throw) in current implementations of connection handlers and in HttpProcessor::Task::run.

Thats why I'm still waiting merging it.
Until I come up with the idea how to handle it better (most probably it will be just catch ignoting the error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants