-
Notifications
You must be signed in to change notification settings - Fork 303
Merging changes for Third party dependencies upgrade #665
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -218,4 +218,4 @@ public void delete(Iterable<? extends E> entities) { | |
} | ||
} | ||
|
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,6 +51,10 @@ | |
<artifactId>oasp4j-test</artifactId> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.springframework.boot</groupId> | ||
<artifactId>spring-boot-starter</artifactId> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we need that for logging module? IMHO there is no need to couple this with spring. |
||
</dependency> | ||
</dependencies> | ||
|
||
</project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,20 +48,20 @@ public BinaryObjectEto saveBinaryObject(Blob data, BinaryObjectEto binaryObjectE | |
@Override | ||
public void deleteBinaryObject(Long binaryObjectId) { | ||
|
||
this.binaryObjectRepository.delete(binaryObjectId); | ||
this.binaryObjectRepository.deleteById(binaryObjectId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Woah. So spring-data changed their API in an incompatible way? That is not so great to here. I will double check... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified. Nothing we can do about it but good that we have these upgrades before we actually spread out spring-data support in devon. |
||
|
||
} | ||
|
||
@Override | ||
public BinaryObjectEto findBinaryObject(Long binaryObjectId) { | ||
|
||
return getBeanMapper().map(this.binaryObjectRepository.findOne(binaryObjectId), BinaryObjectEto.class); | ||
return getBeanMapper().map(this.binaryObjectRepository.find(binaryObjectId), BinaryObjectEto.class); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As it seems the spring-data guys have renamed |
||
} | ||
|
||
@Override | ||
public Blob getBinaryObjectBlob(Long binaryObjectId) { | ||
|
||
return this.binaryObjectRepository.findOne(binaryObjectId).getData(); | ||
return this.binaryObjectRepository.find(binaryObjectId).getData(); | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this query-dsl dependency removed from BOM? Does the new spring-boot parent already come with a more recent version of this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that 4.1.4 is used. Seems fine.