Wrong JSON representation of empty complex <Annotation> #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoTheissen
commented
Dec 16, 2022
| <Term Name="bar" Type="foo.record"/> | ||
| <ComplexType Name="record"> | ||
| <Annotation Term="foo.bar" Qualifier="WithRecord"> | ||
| <Record/> |
There was a problem hiding this comment.
Omitting this empty <Record> should make no difference.
Comment on lines
+11
to
+12
| "@foo.bar#WithRecord": {}, | ||
| "@foo.bar#WithoutRecord": true |
There was a problem hiding this comment.
The default annotation value in JSON depends on whether a <Record> was present in XML.
There was a problem hiding this comment.
Correct. We use Boolean tagging annotations (typically with Type="Core.Tag" DefaultValue="true") a lot, and the code is optimized for this.
This can only be improved if the term definition is read from the referenced vocabulary, which is currently not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.