-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor revision for TC meeting 2024-10-30 #819
Open
tschmidtb51
wants to merge
49
commits into
master
Choose a base branch
from
editor-revision-2024-10-30
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update dates - insert new revision for tracking
- addresses parts of #785 - fix incorrect examples - add new invalid examples
Semantic Versioning - fix examples
Seed Editor revision 2024-10-30
- addresses parts of #563 - add value "optional_patch" - adapt prose
- addresses parts of #563 - add conversion rule for CVRF - add conversion rule from CSAF 2.0
- addresses parts of #662 - add value `fix_planned` as remediation category - adapt prose - restructure mutually exclusive categories
- addresses parts of #662 - add conversion rule from CVRF - add conversion rule from CSAF 2.0 - fix format mistake
- fixes #730 - define filter and search
- addresses parts of #633 - mark test 6.2.10 as obsolete and present reasoning - remove test files for 6.2.10 - adapt test schema and test data list
- addresses parts of #633 - clarify wording regarding required TLP
- addresses parts of #633 - clarify in the wording that it is required, not mandatory to avoid confusion with mandatory tests
- fixes #811 - add comment that not redirects are allowed in requirement 9 and 10
- addresses parts of #674 - add conformance target CSAF Downloader
- instead of fixing the wrong form of enforce removed the enforcement as the schema can only require (the validator may enforce). - calmed the waters even more by removing the word confusion and focusing on documentation and numbering of remaining sections
TLP - remove obsolete test
Revert 788 "Code block syntax"
- addresses review comments from #807 - convert unnecessary upper case to lower case
Co-authored-by: tschmidtb51 <[email protected]>
Remediation categories
Search vs Filter
CSAF Downloader
tschmidtb51
added
editor-revision
already worked on in the editor revision
csaf 2.1
csaf 2.1 work
labels
Oct 30, 2024
tschmidtb51
commented
Oct 30, 2024
- nit: fixed reference to new/reborn date and time section - updated the mappings for sections and examples - rendered the user facing delivery items: single file markdown and html Signed-off-by: Stefan Hagen <[email protected]>
sthagen
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motion set by Thomas Schmidt and seconded by Justin Murphy: https://groups.oasis-open.org/discussion/motion-for-819 |
sthagen
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SLGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
csaf 2.1
csaf 2.1 work
editor-revision
already worked on in the editor revision
motion
This item has a motion pending
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search
andfilter
#730directly
in section 7 #811