Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jinja): webpack_optional global helper #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mirekys
Copy link
Member

@mirekys mirekys commented Jan 21, 2025

This allows for optional inclusion of webpack manifest:

{{ webpack_optional('myentry') }}

If requested manifest not found in manifest.json, no hard error is raised.
Instead, error gets just output to resulting markup as a plain comment:

Screenshot 2025-01-21 at 17 14 53

@mirekys mirekys requested review from Ducica and mesemus January 21, 2025 16:16
@Ducica
Copy link
Contributor

Ducica commented Jan 21, 2025

@mirekys It looks good to me, after we should just make sure to remove all the current overridable registry implementation including the entry point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants