Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckNetworkDeprecations9to10: Check for ifcfg artifacts #1332

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CheckNetworkDeprecations9to10: Check for ifcfg artifacts #1332

wants to merge 3 commits into from

Conversation

lkundrak
Copy link
Contributor

Ifcfg support is going away in RHEL 10.

Let's add a few checks and suggestions so that those poor souls who happen particularly messed up configurations will get a hopefully somewhat helpful heads-up.

https://issues.redhat.com/browse/RHEL-58972

@lkundrak
IfCfg: Move ifcfg model from el8toel9 to common
71c8200 
The ifcfg files went from initscript to native NetworkManager support in
RHEL 9. In RHEL 10, the support for ifcfg files is going away
completely, we'll need the model again.
@lkundrak
IfCfgScanner: Move from el8toel9 to common
e7b4b0d 
The ifcfg files went from initscript to native NetworkManager support in
RHEL 9. In RHEL 10, the support for ifcfg files is going away
completely, we'll need the scanner again.
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@lkundrak
CheckNetworkDeprecations9to10: Check for ifcfg artifacts
d30e6d7 
Ifcfg support is going away in RHEL 10. Try to be a little more helpful,
either suggesting how to migrate automatically, deliver bad news about
migrating legacy policy routing rules manually, or report garbage
after what looks like bad migration (better sad than sorry).

JIRA: https://issues.redhat.com/browse/RHEL-58972
@pirat89 pirat89 added this to the 8.10/9.6 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.10/9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@lkundrak @pirat89