Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add_upgrade_boot_entry): convert arg list into a tuple #1313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(add_upgrade_boot_entry): convert arg list into a tuple #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repos/system_upgrade/common/actors/addupgradebootentry/libraries/addupgradebootentry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def _get_rdlvm_arg_values():
api.current_logger().debug('Collected the following rd.lvm.lv args that are undesired for the squashfs: %s',
rd_lvm_values)

return rd_lvm_values
return tuple(rd_lvm_values)


def construct_cmdline_args_for_livemode():
Expand Down
2 changes: 1 addition & 1 deletion ...s/system_upgrade/common/actors/addupgradebootentry/tests/unit_test_addupgradebootentry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def test_get_rdlvm_arg_values(monkeypatch):

args = addupgradebootentry._get_rdlvm_arg_values()

assert args == ['A', 'B']
assert tuple(args) == ('A', 'B')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_get_rdlvm_arg_values should be already returning a tuple, so shouldn't you be testing:

Suggested change
assert tuple(args) == ('A', 'B')
assert args == ('A', 'B')

otherwise you're asserting that the return value of _get_rdlvm_arg_values can be converted to a tuple matching (A, B)



def test_get_device_uuid(monkeypatch):
Expand Down
Loading