Add pre-commit script and job for syncing scripts to ansible playbooks #7
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 305 305
=========================================
Hits 305 305 ☔ View full report in Codecov by Sentry. |
Wecros
force-pushed
the
mirror-testing
branch
8 times, most recently
from
caa7076 to
7ca1ca6
Compare
|
example of failing check for scripts folder: https://github.com/oamg/leapp-insights-tasks/actions/runs/7548234455/job/20549874644?pr=7 |
pre-commit serves to stage the file without the developer having to do it manually. github job serves to notify the developer if they forgot to run the pre-commit or if they forgot to stage the playbooks changes.
Wecros
force-pushed
the
mirror-testing
branch
from
7ca1ca6 to
aa60972
Compare
There was a problem hiding this comment.
@Monnte please take a look, I would be more in favor to keep the sync from your PR because it's same in conversion repo, would it be adjustable for pre-commit as well as the worker sync? should be almost same right?
There was a problem hiding this comment.
Yep, the sync in my PR should work too. Maybe a little change will be needed to choose target folder to save playbooks.
There was a problem hiding this comment.
Looks good, basically just want answer from @Monnte, but we could merge it and then he can adjust it in his PR
There was a problem hiding this comment.
Alright, it can be merged then, we can adjust the sync in the merge script PR #6
ref: OAMG-9893
pre-commit serves to stage the file without the developer having to do it manually.
github job serves to notify the developer if they forgot to run the pre-commit or if they forgot to stage the playbooks changes.
The playbooks were generated from the new wrap_ script.