packaging: enable engine when it was enabled in answer file #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an answer file that contains: QUESTION/1/OVESETUP_ENGINE_ENABLE=str:yes The CoreEnv.ENABLE was not set to True if fqdn's didn't match and it was not a new database. But as we explicitly want to enable the engine according to the answer file, we must enable it. Signed-off-by: Jean-Louis Dupond <[email protected]>
sandrobonazzola
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an answer file that contains:
QUESTION/1/OVESETUP_ENGINE_ENABLE=str:yes
The CoreEnv.ENABLE was not set to True if fqdn's didn't match and it was not a new database.
But as we explicitly want to enable the engine according to the answer file, we must enable it.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]