-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for 2409.1 point release #784
Merged
spham-amzn
merged 8 commits into
o3de:point-release/24091
from
RobotecAI:jh/pointrelease_cherries
Nov 4, 2024
Merged
Cherry-picks for 2409.1 point release #784
spham-amzn
merged 8 commits into
o3de:point-release/24091
from
RobotecAI:jh/pointrelease_cherries
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix hash for ROS2 Project template * Version bump for the ROS2 Project Template * Fix hashes and versioning for OpenXRTest and Multiplayer template * Regenerated Multiplayer template for repo.json Signed-off-by: Steve Pham <[email protected]>
Co-authored-by: Mateusz Żak <[email protected]> Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Steve Pham <[email protected]>
* add additional logic to apply ROS2Frame conversion to overrides * since the ROS2FrameComponent is not mentioned directly in the patch path use the ROS2FrameComponent field names to correctly identify replacements Signed-off-by: Mateusz Żak <[email protected]>
Signed-off-by: Mateusz Wasilewski <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Michał Pełka <[email protected]> Co-authored-by: Jan Hanca <[email protected]> Co-authored-by: Steve Pham <[email protected]>
This reverts commit bbaece1. Signed-off-by: Jan Hanca <[email protected]> Signed-off-by: Mateusz Zak <[email protected]>
jhanca-robotecai
force-pushed
the
jh/pointrelease_cherries
branch
from
October 31, 2024 12:56
c0b719a
to
0ffe3c2
Compare
Force-pushed to fix DCO |
spham-amzn
approved these changes
Nov 1, 2024
michalpelka
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against released binary o3de 2409 in 4 scenarios:
- all three templates
- roscon demo2023 (development branch).
Works as intended on Ubuntu 2204 with ROS 2 Humble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR cherry-picks commits that should be included in the point release
2409.1
. This includes the following PRs with the following reasoning:stabilization/2409
branch after the release; it was used to generate the binary packages, but it was missing in themain
branchstabilization/2409
branch after the release; it was used to generate the binary packages, but it was missing in themain
branchstabilization/2409
branch after the release; it was used to generate the binary packages, but it was missing in themain
branchFollowingCameraComponent
unusable withFlyCameraComponent
(the problem existed since 2310.0)NOTE: when this PR is merged, there should be one more fix to follow, in which
3.2.2
as discussed on Discord channelrepo.json
file is regenerated to include files added in Registry setting for pipeline modification. #781How was this PR tested?
ROS2ProjectTemplate was built and tested; more tests with other templates should follow