Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for 2409.1 point release #784

Merged

Conversation

jhanca-robotecai
Copy link
Contributor

What does this PR do?

This PR cherry-picks commits that should be included in the point release 2409.1. This includes the following PRs with the following reasoning:

NOTE: when this PR is merged, there should be one more fix to follow, in which

How was this PR tested?

ROS2ProjectTemplate was built and tested; more tests with other templates should follow

* Fix hash for ROS2 Project template
* Version bump for the ROS2 Project Template
* Fix hashes and versioning for OpenXRTest and Multiplayer template
* Regenerated Multiplayer template for repo.json

Signed-off-by: Steve Pham <[email protected]>
jhanca-robotecai and others added 7 commits October 31, 2024 13:54
* add additional logic to apply ROS2Frame conversion to overrides
* since the ROS2FrameComponent is not mentioned directly in the patch path use the ROS2FrameComponent field names to correctly identify replacements

Signed-off-by: Mateusz Żak <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
Co-authored-by: Jan Hanca <[email protected]>
Co-authored-by: Steve Pham <[email protected]>
This reverts commit bbaece1.

Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Mateusz Zak <[email protected]>
@jhanca-robotecai
Copy link
Contributor Author

Force-pushed to fix DCO

Copy link
Contributor

@michalpelka michalpelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against released binary o3de 2409 in 4 scenarios:

  • all three templates
  • roscon demo2023 (development branch).
    Works as intended on Ubuntu 2204 with ROS 2 Humble.

@spham-amzn spham-amzn merged commit 427e8f0 into o3de:point-release/24091 Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants