Use simulation time to compute time difference. #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrcolin
added
the
sig/simulation
jhanca-robotecai
approved these changes
Jul 12, 2024
Gems/ROS2/Code/Include/ROS2/Manipulation/MotorizedJoints/JointMotorControllerComponent.h
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/Manipulation/JointsManipulationComponent.h
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Include/ROS2/Manipulation/MotorizedJoints/JointMotorControllerComponent.h
Outdated
Show resolved
Hide resolved
|
Applied review comments |
|
I would consider cherry-picking it to stabilization as well. |
jhanca-robotecai
approved these changes
Jul 15, 2024
adamdbrw
approved these changes
Jul 18, 2024
|
Please rebase it on top of the |
Signed-off-by: Michał Pełka <[email protected]>
Co-authored-by: Jan Hanca <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
jhanca-robotecai
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Michał Pełka <[email protected]> Co-authored-by: Jan Hanca <[email protected]>
jhanca-robotecai
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Aug 13, 2024
Signed-off-by: Michał Pełka <[email protected]> Co-authored-by: Jan Hanca <[email protected]>
jhanca-robotecai
added a commit
that referenced
this pull request
Aug 21, 2024
Signed-off-by: Michał Pełka <[email protected]> Co-authored-by: Jan Hanca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes number of places in codebase, where delta time is used.
In current development (and release) the delta time was taken from AZ::TickBus::OnTick.
That is a time between two OnTick. It is not simulation time.
I've changed code to get simulation time.
How was this PR tested?
Build and run. The test effort should be part of #710