Skip to content

Commit

Permalink
Final checks before 0.6.3 beta release
Browse files Browse the repository at this point in the history
  • Loading branch information
o355 committed Dec 3, 2017
1 parent 7f394ba commit 3eb7c57
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 39 deletions.
12 changes: 8 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@
* Adds the ability for configsetup to run an automatic geocoder scheme
* Improves the disabling of having a custom geocoder API key, even though the scheme is set to HTTP (custom geocoder keys only work with HTTPS.
* Improves the UI in the setup file to not have overflowing lines of text.
* Adds an attribution to Meteoalarm for EU-based alerts
* Adds better exiting at multiple input prompts throughout PyWeather

## version 0.6.3 beta - Should be released on on December 2:
## version 0.6.3 beta - Released on 12/2/2017:
* Adds a nearby location feature to hurricane data (300km out)
* Will push the API key validation code up further thanks to new features.
* Adding a much nicer progress indicator.
Expand All @@ -29,7 +31,6 @@
* Adding the ability to show cache timings.
* Adds a new loader, which makes loading things in PyWeather a lot more nice.
* The ability to see pressure and visibility data has been added to historical hourly & yesterday hourly information.
* Adds an attribution to Meteoalarm for EU-based alerts
* Minor UI changes.

**BUG FIXES**
Expand All @@ -49,11 +50,14 @@
* Fixed a minor bug where PyWeather wouldn't catch bad humidity data for current conditions.
* Fixed a bug where configsetup script set the default geocoder scheme to https, which caused issues on platforms that don't support the geocoder running in the HTTPS scheme.


**OTHER CHANGES**
**OTHER CHANGES:**
* The Git Updater has been completely removed, as it's been unreliable. A universal updater will be introduced later in time.
* The configupdate file will now properly catch a bad section error (not a plain except)

**KNOWN ISSUES:**
* Tide data may not be fully available for some cities. I'm working on a fix for 0.6.4 beta.
* Attempting to exit out of historical weather is bugged. I'm also working on a fix for 0.6.4 beta.
* Hurricanes in hurricane data will show up twice. I've already contacted Wunderground about the issue, but they haven't responded back. A fix is coming in 0.6.4 beta.

## version 0.6.2 beta - Released on 9/24/2017
**NEW FEATURES/REMOVALS**
Expand Down
3 changes: 2 additions & 1 deletion configupdate.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
print("Updating PyWeather using version identifier: 0.6.1 beta")
versioninfo2 = "0.6.1 beta"
elif versioninfo2 == "3":
print("Updating PoyWeather using version identifier: 0.6.2 beta")
print("Updating PyWeather using version identifier: 0.6.2 beta")
versioninfo2 = "0.6.2 beta"

config = configparser.ConfigParser()
Expand Down Expand Up @@ -493,6 +493,7 @@ def installhalo():
print("Could not write out an updated versioninfo text file. Please",
"modify 'updater/versioninfo.txt' to display '0.6.2 beta'.", sep="\n")

print("")
print("Ta-da! PyWeather is all up-to-date. Enjoy the new features and bug fixes!",
"Press enter to exit.", sep="\n")
input()
Expand Down
40 changes: 7 additions & 33 deletions pyweather.py
Original file line number Diff line number Diff line change
Expand Up @@ -728,38 +728,12 @@ def radar_clearImages():
geolocator = GoogleV3(scheme='http')
logger.debug("geocoder scheme is now http.")
elif geopyScheme == "http" and geocoder_customkeyEnabled is True:
geolocator = GoogleV3(api_key=geocoder_customkey, scheme='http')
logger.debug("geocoder scheme is now http, custom key. Validating...")
spinner.stop()
spinner.start(text="Validating geocoder API key...")
# Do a warm-up geocode
try:
location = geolocator.geocode("123 5th Avenue, New York, NY")
except:
logger.debug("warmup geocode failed.")
# Do the actual geocode
try:
location = geolocator.geocode("123 5th Avenue, New York, NY")
except geopy.exc.GeocoderQueryError:
spinner.fail(text="Geocoder API key is invalid!")
print("")
logger.debug("API key is invalid, falling back to no API key...")
print("Your geocoder API key failed to validate, since it is wrong.",
"Falling back to no API key...", sep="\n")
printException()
geolocator = GoogleV3(scheme='http')
time.sleep(0.1)
spinner.start(text="Loading PyWeather...")
except:
spinner.fail(text="Failed to validate geocoder API key!")
print("")
print("When trying to validate your geocoder API key, something went wrong.",
"Falling back to no API key...", sep="\n")
printException()
logger.debug("Failed to validate API key.")
geolocator = GoogleV3(scheme='http')
time.sleep(0.1)
spinner.start(text="Loading PyWeather...")
spinner.fail(text="A custom geocoder key on a HTTP scheme isn't allowed!")
print("Sorry! Having a custom geocoder key on a HTTP scheme is not supported by",
"Google. If you want to get rid of these error messages, please set GEOCODER API/",
"customkeyenabled to False.", sep="\n")
print("")
geolocator = GoogleV3(scheme='http')
else:
print("Geocoder scheme variable couldn't be understood.",
"Defaulting to the https scheme.", sep="\n")
Expand Down Expand Up @@ -906,7 +880,7 @@ def radar_clearImages():
logger.info("Defining about variables...")
about_buildnumber = "63"
about_version = "0.6.3 beta"
about_releasedate = "November 30, 2017"
about_releasedate = "December 2, 2017"
about_maindevelopers = "o355" # Oh look, I'm also on TV, HI MOM!!!!!!!!!!!!
logger.debug("about_buildnumber: %s ; about_version: %s" %
(about_buildnumber, about_version))
Expand Down
2 changes: 1 addition & 1 deletion updater/versioncheck.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"latesturl": "https://github.com/o355/pyweather/releases/download/0.6.2-beta/pyweather-0.6.2beta.zip",
"latestfilename": "pyweather-0.6.2beta.zip",
"releasedate": "September 24, 2017",
"nextversionreleasedate": "December 1, 2017"
"nextversionreleasedate": "December 2, 2017"
}
}

0 comments on commit 3eb7c57

Please sign in to comment.