-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added copy export, to fix #171 #190
base: master
Are you sure you want to change the base?
Conversation
@@ -45,7 +45,7 @@ Here is an example using `mtcars`. First, we specify the imperial units to those | |||
|
|||
```{r} | |||
library(units) | |||
gallon = make_unit("gallon") | |||
gallon = as_units("gallon") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant news on deprecation: https://cran.r-project.org/web/packages/units/news/news.html
@@ -36,7 +36,7 @@ df <- dockerfile(from = info) | |||
A shortcut to this is provided with the function `containerit::clean_session(..)`: | |||
|
|||
```{r bioc_dockerfile_clean_session, results='hide'} | |||
containerit::clean_session(expr = quote(library("BiocGenerics"))) | |||
containerit::clean_session(expr = c(quote(library("BiocGenerics")))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first still should work (hence the fix above), but figured the vignette should show the "right" way to do it.
Some failures seem due to new sysreqs coming into play https://ci.appveyor.com/project/nuest/containerit-rrvpq/builds/41103797#L1538 |
Microbadger is shudown: https://twitter.com/microscaling/status/1361054926399557644?s=20 |
This also has the enhancement of sysreqs to fixing #193 |
I've also added output for Add and Env in my version. |
I think we're goign to simply move forward in our work with these changes and rely on my version. Let me know if, in the future, there's anything I can do to incorporate this into the main branch. |
Simply added example and copy export, to fix #171