Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added copy export, to fix #171 #190

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

muschellij2
Copy link

Simply added example and copy export, to fix #171

@@ -45,7 +45,7 @@ Here is an example using `mtcars`. First, we specify the imperial units to those

```{r}
library(units)
gallon = make_unit("gallon")
gallon = as_units("gallon")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -36,7 +36,7 @@ df <- dockerfile(from = info)
A shortcut to this is provided with the function `containerit::clean_session(..)`:

```{r bioc_dockerfile_clean_session, results='hide'}
containerit::clean_session(expr = quote(library("BiocGenerics")))
containerit::clean_session(expr = c(quote(library("BiocGenerics"))))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first still should work (hence the fix above), but figured the vignette should show the "right" way to do it.

@muschellij2
Copy link
Author

Some failures seem due to new sysreqs coming into play https://ci.appveyor.com/project/nuest/containerit-rrvpq/builds/41103797#L1538

@muschellij2
Copy link
Author

@muschellij2
Copy link
Author

This also has the enhancement of sysreqs to fixing #193

@muschellij2
Copy link
Author

I've also added output for Add and Env in my version.

@muschellij2
Copy link
Author

I think we're goign to simply move forward in our work with these changes and rely on my version. Let me know if, in the future, there's anything I can do to incorporate this into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom COPY additions not exported
2 participants