Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the necessarry inversions of the witness in batch after it's creation #2760

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

marcbeunardeau88
Copy link
Contributor

@marcbeunardeau88 marcbeunardeau88 commented Nov 19, 2024

Follow-up of #2047
but we proceed differently.
The witness env now contains a set marking which element are to be inverted.
The Batch inversion is then done when creating the ProofInput.
We first create an intermediary type NotInversedProofInput, and implement a conversion to ProofInput which does the batch inversion

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 15.58442% with 65 lines in your changes missing coverage. Please review.

Project coverage is 72.60%. Comparing base (9130939) to head (5a76ff8).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/pickles/proof.rs 0.00% 38 Missing ⚠️
o1vm/src/pickles/main.rs 0.00% 15 Missing ⚠️
o1vm/src/interpreters/mips/witness.rs 42.85% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   73.71%   72.60%   -1.11%     
==========================================
  Files         249      255       +6     
  Lines       57866    59474    +1608     
==========================================
+ Hits        42654    43184     +530     
- Misses      15212    16290    +1078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dannywillems dannywillems self-requested a review November 19, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant