refacator: update create table process creation

Signed-off-by: Otavio Santana <[email protected]>
o-s-expert · Nov 28, 2023 · 20e4f3d · 20e4f3d
1 parent 03e7b07
commit 20e4f3d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/core/src/main/java/expert/os/harperdb/CreateTableBuilder.java b/core/src/main/java/expert/os/harperdb/CreateTableBuilder.java
@@ -66,7 +66,7 @@ private TableBuilder(String schema, String table, Server server) {
  */
  public boolean id(String id) {
  Objects.requireNonNull(id, "id is required");
- return this.server.createTable(new CreateTable(schema, table, id));
+ return this.server.executeTableCreation(new CreateTable(schema, table, id));
  }
  }
 }
diff --git a/core/src/main/java/expert/os/harperdb/Server.java b/core/src/main/java/expert/os/harperdb/Server.java
@@ -57,12 +57,12 @@ public boolean schema(String schema) {
  * @return A CreateTableBuilder instance to further configure the "create table" operation.
  * @throws NullPointerException if the provided schema is null.
  */
- public CreateTableBuilder table(String schema){
+ public CreateTableBuilder createTable(String schema){
  Objects.requireNonNull(schema, "schema is required");
  return new CreateTableBuilder(schema, this);
  }
 
- boolean createTable(CreateTable operation) {
+ boolean executeTableCreation(CreateTable operation) {
  HttpRequest request = createRequest()
  .POST(ofByteArray(INSTANCE.writeValueAsBytes(operation)))
  .build();

diff --git a/core/src/test/java/expert/os/harperdb/ServerTest.java b/core/src/test/java/expert/os/harperdb/ServerTest.java
@@ -1,11 +1,8 @@
 package expert.os.harperdb;
 
-import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.*;
-
 class ServerTest {
 
  private final Container container = Container.INSTANCE;
@@ -38,9 +35,9 @@ void shouldNotCreateSchemaDuplicated() {
  void shouldReturnNPEWhenSchemaIsNull() {
  Server server = getServer();
 
- Assertions.assertThrows(NullPointerException.class, () -> server.table(null));
- Assertions.assertThrows(NullPointerException.class, () -> server.table("schema").table(null));
- Assertions.assertThrows(NullPointerException.class, () -> server.table("schema").table("table").id(null));
+ Assertions.assertThrows(NullPointerException.class, () -> server.createTable(null));
+ Assertions.assertThrows(NullPointerException.class, () -> server.createTable("schema").table(null));
+ Assertions.assertThrows(NullPointerException.class, () -> server.createTable("schema").table("table").id(null));
  }
 
  private Server getServer() {