Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start unification of QuakeGX #33

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Start unification of QuakeGX #33

wants to merge 21 commits into from

Conversation

tyleryoung88
Copy link

No description provided.

MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/cdaudio.h Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/cl_input.c Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/cl_input.c Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/cl_main.c Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/cl_main.c Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/draw.h Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/draw.h Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/draw.h
#elif __WII__
qpic_t *Draw_LMP (char *path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep LMP and CachePic logic separate on this platform. Whenever these functions are consolidated it creates a small lag when drawing Textboxes. This is because there are 5 file open/closes for 10 total textures loaded in coupled with slow IO speeds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. We shouldn't be using lmp anywhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmp is used to draw the console keyboard background.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. We should depreciate this in favor of drawing it in engine.

MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/host.c Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy reviewed Sep 14, 2024
View reviewed changes
source/mathlib.h Outdated Show resolved Hide resolved
MotoLegacy
MotoLegacy requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@MotoLegacy MotoLegacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MotoLegacy MotoLegacy Awaiting requested review from MotoLegacy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyleryoung88 @MotoLegacy