Patch ejira-core to refer to users via accountId #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There must be some changes to, but user mentions require using
"accountId" field from whatever data we receive from API listing all
users.
Also, assigning issues no longer works by full name, complaining about
GDPR, so I had to pass accountId to jiralib2-assign-issue function,
and redefine it to use it as following:
(defun jiralib2-assign-issue (issue-key account)
"Assign issue with ISSUE-KEY to USERNAME."
(jiralib2-session-call (format "/rest/api/2/issue/%s/assignee" issue-key)
:type "PUT"
:data (json-encode `((accountId . ,account)))))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for this nice piece of software.
It may be specific to configuration of my corporate jira (I mean, clearly if assigning issues and making mentions were not working at all, people would notice, although #37 mentions same GDPR error as I have).
It is very odd, but mentions format we have right now does not work for me, I did some experimenting involving
web browser and mentioning innocent people, and came to format I propose in this pull request.
I am not sure what is GDPR strict mode is, but probably referring to users by accoutId instead of full names is better in general, since it will less likely to break on people with complicated Unicode names or people with same names or something like this.
Closing this PR with
works fine for meis okay; as I said this may be related to my particular instance of jira (I am not admin of it), but I though it would be nice to inform you about these issues.