-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mention #34 and input granularity issues and fix grid drawing bug
- the zoom range does not get updated depending on the input. This causes issues with datasets that require a wider range. Increased the range for now. Filed as #34. - Datasets that have an event granularity (minTimeDiff) that is too small become flat/invisible lines (aspect ratio). Mentioned this behaviour, which can be avoided by binning timestamps, in `spec.md`. If this level of granularity is needed a way to manually set minTimeDiff could possibly be created but might break all assumptions about co-occurring events in the code base. - the grid drawing routine previously used the svgport for determining the sizes of the lines which is wrong (lines would normally extend beyond the viewport due to this so it wasn't noticeable)
- Loading branch information
1 parent
f311bea
commit ae38369
Showing
3 changed files
with
18 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters