Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change win64 numpy default int32 to int64 #1325

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jian-mo
Copy link

@jian-mo jian-mo commented Jul 5, 2021

add dtype specification for the random seed so that win64 numpy can use correct int64 rather than 32 bit int which will not be long enough for the seed

@jian-mo jian-mo requested review from jeswan and zphang as code owners July 5, 2021 07:30
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1325 (8535c63) into master (310f22b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files         162      162           
  Lines       11210    11210           
=======================================
  Hits         5580     5580           
  Misses       5630     5630           
Impacted Files Coverage Δ
jiant/shared/initialization.py 33.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310f22b...8535c63. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant