This repository has been archived by the owner on Mar 6, 2019. It is now read-only.
test showing sorts fail to chain #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, taking over this repo (with teammates) after @esmooov's departure from NYT. I'll be reviewing this and merging once I wrap my head around some of its implications. |
tiffehr
added a commit
that referenced
this pull request
Oct 7, 2015
test showing sorts fail to chain
|
Merged in, but it may take me some time to properly address the test. Opening a separate Issue (#63) for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request, really. While it's easy enough to make a single sort fn that captures the logic of two or more semantically atomic sorts, having to do so for every possible combination of sorts seems silly.