Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow debug log flag #95

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Allow debug log flag #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,15 @@ in [entrypoint.sh](https://github.com/nylonee/watchlistarr/blob/main/docker/entr
| ALLOW_ENDED_SHOW_DELETING | false | Boolean flag to enable/disable the full Watchlistarr sync for ended shows. If enabled, shows that have no more planned seasons and are not watchlisted will be deleted from Sonarr |
| ALLOW_CONTINUING_SHOW_DELETING | false | Boolean flag to enable/disable the full Watchlistarr sync for continuing shows. If enabled, shows that still have planned seasons and are not watchlisted will be deleted from Sonarr |
| DELETE_INTERVAL_DAYS | 7 | Number of days to wait before deleting content from the arrs (Deleting must be enabled) |
| LOG_LEVEL | INFO | Level of logging, set to DEBUG for more verbose logs, or WARN for less logs |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the LOG_LEVEL configuration option is well-documented. Ensure that the documentation clearly specifies the acceptable values for LOG_LEVEL and their impact on logging verbosity.


## Plex Pass Alternative
The Plex Pass subscription is required to generate the RSS Feed URLs. Without a Plex Pass, the normal API calls are too heavy-hitting on Plex's servers.

If the app detects that you are not a Plex Pass user (i.e. the app tries to generate an RSS URL, and it fails), it will fall back into a periodic sync.
The Plex Pass subscription is required to generate the RSS Feed URLs. Without a Plex Pass, the normal API calls are too
heavy-hitting on Plex's servers.

If the app detects that you are not a Plex Pass user (i.e. the app tries to generate an RSS URL, and it fails), it will
fall back into a periodic sync.
Comment on lines +130 to +134
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clarification regarding the necessity of a Plex Pass for generating RSS Feed URLs is helpful. Ensure that the explanation of the fallback mechanism for non-Plex Pass users is clear and concise, possibly by providing an example or more detailed description of how the periodic sync operates.


The periodic sync will run every 19 minutes, ignoring the configuration for REFRESH_INTERVAL_SECONDS

Expand Down
4 changes: 4 additions & 0 deletions docker/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,8 @@ if [ -n "$RADARR_TAGS" ]; then
CMD+=("-Dradarr.tags=$RADARR_TAGS")
fi

if [ -n "$LOG_LEVEL" ]; then
CMD+=("-Dlog.level=$LOG_LEVEL")
fi
Comment on lines +94 to +96
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the LOG_LEVEL variable is properly validated to prevent potential command injection or unexpected behavior. Consider adding a check to ensure it only contains expected values (e.g., DEBUG, INFO, WARN).


exec "${CMD[@]}" "${JAVA_OPTS[@]}"
2 changes: 1 addition & 1 deletion src/main/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</encoder>
</appender>

<root level="INFO">
<root level="${log.level:-INFO}">
<appender-ref ref="STDOUT" />
</root>
</configuration>
Loading