test for quality profile ID

[nylonee]

Closes #72

Summary by CodeRabbit

• Tests
  • Introduced a new test case for handling multi-word quality profiles.
• Refactor
  • Updated mock configuration reader to support a new qualityProfile parameter.
• Chores
  • Modified mock HTTP client to utilize JSON files for test data instead of hardcoded values.

[coderabbitai]

Walkthrough

The recent updates have introduced the capability to handle quality profiles with multi-word names. This enhancement was driven by the need to match profiles more accurately, as single-word limitations were causing mismatches. The codebase now includes a test for this specific case and has seen adjustments in configuration reading and HTTP client mock-ups to support the new functionality.

Changes

File Path	Change Summary
.../configuration/ConfigurationUtilsSpec.scala	Added a test case for multi-word quality profiles; updated createMockConfigReader and createMockHttpClient methods.

Assessment against linked issues

Objective	Addressed	Explanation
Allow quality profiles with spaces in their name (#72)	✅	The changes include updates to handle quality profiles with spaces, which addresses the main objective of the issue.

Poem

To code with grace, we hop and tweak, 🐇💻
Spaces in names, no longer unique.
A rabbit's touch, the profiles align,
With multi-words, they now combine. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between cd65f49 and e464981.

Files ignored due to filter (1)

• src/test/resources/quality-profile.json

Files selected for processing (1)

• src/test/scala/configuration/ConfigurationUtilsSpec.scala (3 hunks)

Additional comments: 6

src/test/scala/configuration/ConfigurationUtilsSpec.scala (6)

• 143-152: The new test case for handling quality profiles with multiple words seems to be correctly implemented. It checks that no exception is thrown and that the quality profile IDs for both sonarr and radarr configurations are as expected.

• 161-162: The addition of the qualityProfile parameter to the createMockConfigReader method aligns with the PR's objective to handle quality profiles with spaces. This change allows for more flexible test configurations.

• 170-170: The expectation for Keys.sonarrQualityProfile to return the qualityProfile parameter is correctly set up to allow testing of quality profiles with spaces.

• 175-175: Similarly, the expectation for Keys.radarrQualityProfile to return the qualityProfile parameter is correctly set up, ensuring that the test can verify the handling of quality profiles with spaces for radarr configurations.

• 198-198: The update to the httpRequest call for fetching sonarr quality profiles to read from a JSON file instead of a hardcoded list is a good improvement. It enhances the flexibility and accuracy of the tests.

• 210-210: The update to the httpRequest call for fetching radarr quality profiles to read from the same JSON file is consistent with the changes made for sonarr. This ensures that both sonarr and radarr are tested under the same conditions.