Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maximum memory #60

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Set maximum memory #60

merged 1 commit into from
Dec 19, 2023

Conversation

nylonee
Copy link
Owner

@nylonee nylonee commented Dec 19, 2023

The docker file is now set to have a maximum memory limit of 100M

Running this natively, this needs to be set via a parameter as well, I have updated the README to reflect how this can be done

Fixes #37

Copy link

coderabbitai bot commented Dec 19, 2023

Warning

Rate Limit Exceeded

@nylonee has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 3 minutes and 42 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 930d768 and 90117a7.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@nylonee nylonee merged commit 76e4261 into main Dec 19, 2023
2 checks passed
@nylonee nylonee deleted the nylonee/reduce-xmx branch December 19, 2023 22:51
@samcro1967
Copy link

This does not appear to be having an impact on the docker image. Limiting memory when deploying the container seems to be working as an alternative solution.

Docker Compose:

  watchlistarr:
    hostname: watchlistarr
    image: nylonee/watchlistarr
    container_name: watchlistarr
    restart: always
    volumes:
      - ${docker}/watchlistarr:/app/config
    logging:
      driver: "json-file"
      options:
        max-size: "10m"
        max-file: "3"
    deploy:
      resources:
        limits:
          memory: 100M

Before:

CONTAINER ID   NAME           CPU %     MEM USAGE / LIMIT     MEM %     NET I/O          BLOCK I/O         PIDS
fc464e74a8af   watchlistarr   0.11%     11.45GiB / 7.749GiB   147.79%   85.8GB / 140MB   10.1GB / 9.39GB   54

After:

CONTAINER ID   NAME           CPU %     MEM USAGE / LIMIT   MEM %     NET I/O           BLOCK I/O       PIDS
849c5b5a2dce   watchlistarr   10.78%    99.89MiB / 100MiB   99.89%    1.37MB / 69.1kB   738MB / 358MB   31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark and reduce memory allocation
2 participants