-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random parameter to RSS URLs overcome server-side caching #183
Conversation
WalkthroughThe modification in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/scala/plex/PlexUtils.scala (1 hunks)
Additional comments not posted (1)
src/main/scala/plex/PlexUtils.scala (1)
24-24
: Ensure proper URL construction with random parameter.The addition of the random parameter
r
to the RSS URL is implemented correctly using Scala'sRandom.alphanumeric.take(10).mkString
. This approach should effectively bypass server-side caching by making each URL unique. However, consider the following improvements:
- Security and Performance Considerations: Ensure that the randomness and length of the parameter are sufficient to prevent potential security issues related to predictability and caching efficiency.
- Code Clarity: While the current implementation is concise, adding a brief comment explaining the purpose of the
r
parameter could improve code maintainability.The change is logical and aligns with the PR's objectives. However, consider the suggested improvements for enhanced security and clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Heya, thanks for this! I wanted to make some minor changes but it looks like I can't edit your branch so I've made a new branch here: #190 (Sorry I've been overseas for a while, back now) |
Description
Plex has added server-side caching to their watchlist RSS feeds, this change appends a parameter "r" to the RSS URL along with a random 10 character alphanumeric value to overcome this caching.
Summary by CodeRabbit