Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new ubuntu version #141

Closed
wants to merge 11 commits into from
Closed

use new ubuntu version #141

wants to merge 11 commits into from

Conversation

ankit16-19
Copy link
Collaborator

@ankit16-19 ankit16-19 commented Apr 23, 2024

Description

Github doesn't support old ubuntu version.

Seems to be working now:
ankit16-19#1 (comment)

Checklist

  • Documentation Updated
  • sbt scalafmtAll Run (and optionally sbt scalafmtSbt)
  • At least one approval from a codeowner

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflows to enhance Docker image building and pushing processes.
    • Modified workflows to trigger on specific branch patterns and updated to the latest Ubuntu version for better performance and compatibility.

Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent updates across various GitHub Actions workflows primarily enhance Docker operations, including the setup of QEMU and Buildx, and the introduction of new tagging and labeling strategies for Docker images. These changes aim to streamline CI/CD pipelines by improving automation and compatibility across different computing platforms.

Changes

File Path Change Summary
.github/workflows/docker-alpha.yml
.github/workflows/docker-beta.yml
.github/workflows/release-docker.yml
Updated to include environment variables, Docker metadata action, QEMU and Buildx setup, and enhanced Docker image building and pushing capabilities with specific tags and labels.
.github/workflows/merge-preview.yml Updated to run on the latest version of Ubuntu instead of Ubuntu 18.04.

🐰✨
Oh hark! The workflows dance anew,
With Docker's charm in splendid view.
Buildx and QEMU join the fray,
Tags and labels in bright array.
In Ubuntu's latest garb they play,
Cheers to changes, hip hooray!
🎉🐇


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a7e1dcc and 962ded3.
Files selected for processing (4)
  • .github/workflows/docker-alpha.yml (1 hunks)
  • .github/workflows/docker-beta.yml (1 hunks)
  • .github/workflows/merge-preview.yml (1 hunks)
  • .github/workflows/release-docker.yml (1 hunks)
Additional comments not posted (7)
.github/workflows/merge-preview.yml (1)

10-10: Update to ubuntu-latest is appropriate given the deprecation of Ubuntu 18.04.

Please ensure that all actions and dependencies in this workflow are compatible with the latest Ubuntu version.

.github/workflows/docker-beta.yml (2)

7-10: Introduction of new environment variables is well-structured.

Please verify that the environment variables APP_NAME, DOCKER_FILE, and DOCKER_PLATFORMS are correctly configured in the repository settings or the Dockerfile.


24-50: Enhancements to Docker workflow including metadata handling and cross-platform builds are correctly implemented.

Ensure that the Docker metadata and build configurations work as expected across all specified platforms.

.github/workflows/docker-alpha.yml (2)

4-5: Trigger pattern for branches is correctly set for alpha releases.

Confirm that the branch pattern "actions-merge-preview/**" is correctly configured for the intended use cases.


25-51: Setup for Docker metadata, QEMU, Buildx, and image pushing is well-implemented for alpha releases.

Ensure that the Docker configurations and metadata are correctly applied and functional in the alpha context.

.github/workflows/release-docker.yml (2)

7-10: Environment variables for the Docker release workflow are correctly set.

Please verify that the environment variables APP_NAME, DOCKER_FILE, and DOCKER_PLATFORMS are correctly configured for release builds.


26-53: Inclusion of semantic versioning in Docker tags and setup for cross-platform builds are well-implemented.

Ensure that the semantic versioning tags are correctly generated and that Docker builds are successful across all specified platforms.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankit16-19 ankit16-19 mentioned this pull request Apr 23, 2024
3 tasks
@ankit16-19 ankit16-19 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant