-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for ARM64 #136
Conversation
WalkthroughThe Docker build workflows have undergone a comprehensive overhaul, enhancing the structure and integration of environment variables, Docker actions, and the overall build process. This includes better handling of metadata, and more efficient setups for QEMU and Docker Buildx, culminating in improved image building and pushing mechanisms. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Additional comments not posted (12)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
.github/workflows/docker-beta.yml (1)
37-41
: The configuration for Docker Buildx is set to debug mode. Ensure that this is intended for production or adjust it accordingly.Consider setting the
buildkitd-flags
to a less verbose level unless detailed logs are necessary for debugging purposes..github/workflows/docker-alpha.yml (1)
37-41
: The configuration for Docker Buildx is set to debug mode. Ensure that this is intended for production or adjust it accordingly.Consider setting the
buildkitd-flags
to a less verbose level unless detailed logs are necessary for debugging purposes..github/workflows/release-docker.yml (1)
39-43
: The configuration for Docker Buildx is set to debug mode. Ensure that this is intended for production or adjust it accordingly.Consider setting the
buildkitd-flags
to a less verbose level unless detailed logs are necessary for debugging purposes.
@nylonee So it's didn't work. Have a look at this discussion. This solution seems to work: There are two ways to implements this (excluding the manual way)
Which way do you things makes sense to you? In both the cases you would need to add a workflow/action-bot in your master. Let me know which way your preffer. |
Ah I see, these are all interesting solutions I like the github actions one, but I don't have a lot of time to implement this (I'll be away for the next few weeks) Let me get your feature force-merged into a branch on my repo, and then raise another PR to If you work off the |
Description
Adding support for ARM64 releases.
Breaking changes:
Earlier we were using date to tag docker releases.
I have used sha for the same. Rest all remains same.
Checklist
sbt scalafmtAll
Run (and optionallysbt scalafmtSbt
)Summary by CodeRabbit