Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ARM64 #135

Closed
wants to merge 10 commits into from
Closed

Add Support for ARM64 #135

wants to merge 10 commits into from

Conversation

ankit16-19
Copy link
Collaborator

@ankit16-19 ankit16-19 commented Apr 23, 2024

Description

Adding support for ARM64 releases.

Breaking changes:

  • Earlier we were using date to tag docker releases.
  • I have used sha for the same. Rest all remains same.

Checklist

  • Documentation Updated
  • sbt scalafmtAll Run (and optionally sbt scalafmtSbt)
  • At least one approval from a codeowner

Summary by CodeRabbit

  • Chores
    • Enhanced Docker build workflows to improve image creation and deployment processes across different environments (alpha, beta, and release stages).

Copy link

coderabbitai bot commented Apr 23, 2024

Walkthrough

The recent updates to the GitHub workflow files revolve around enhancing Docker workflows. These enhancements include the introduction of new environment variables, the restructuring of steps, and the addition of various actions such as Docker metadata, QEMU setup, Buildx setup, and the build/push processes for Docker images.

Changes

File Path Summary of Changes
.github/workflows/docker-*.yml Added environment variables, reorganized steps, introduced metadata, QEMU, Buildx setup, and updated Docker image building/pushing actions.

Poem

🐇💻✨
In the realm of code, under moon's glow,
A rabbit hopped, with changes in tow.
Docker files dance, with new steps aligned,
Building images sleek, leaving old ways behind.
Cheers to the craft, and updates that flow!
🌟🚀🐰


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 71365e6 and 536659a.
Files selected for processing (3)
  • .github/workflows/docker-alpha.yml (1 hunks)
  • .github/workflows/docker-beta.yml (1 hunks)
  • .github/workflows/release-docker.yml (1 hunks)
Additional comments not posted (12)
.github/workflows/docker-beta.yml (4)

7-10: Ensure the new environment variables are documented.

Please verify that the new environment variables (APP_NAME, DOCKER_FILE, DOCKER_PLATFORMS) are documented in the project's README or relevant documentation to ensure they are properly understood and utilized by other developers or in CI/CD pipelines.


24-33: Validate Docker metadata configuration.

Ensure that the Docker metadata configuration, including tags and labels, is correctly set up to reflect the intended Docker image properties. This is crucial for image versioning and management.


34-41: Check compatibility of Docker Buildx and QEMU setup.

Confirm that the Docker Buildx and QEMU setup actions (docker/[email protected] and docker/[email protected]) are compatible with the project's requirements and that they function correctly across all intended platforms, especially the newly added ARM64.


42-50: Review Docker build and push configurations.

Review the configuration for building and pushing Docker images to ensure that it aligns with the project's deployment and versioning strategies. This includes checking the context, file paths, platforms, and the push settings.

.github/workflows/docker-alpha.yml (4)

7-10: Ensure the new environment variables are documented.

Please verify that the new environment variables (APP_NAME, DOCKER_FILE, DOCKER_PLATFORMS) are documented in the project's README or relevant documentation to ensure they are properly understood and utilized by other developers or in CI/CD pipelines.


25-34: Validate Docker metadata configuration.

Ensure that the Docker metadata configuration, including tags and labels, is correctly set up to reflect the intended Docker image properties. This is crucial for image versioning and management.


35-42: Check compatibility of Docker Buildx and QEMU setup.

Confirm that the Docker Buildx and QEMU setup actions (docker/[email protected] and docker/[email protected]) are compatible with the project's requirements and that they function correctly across all intended platforms, especially the newly added ARM64.


43-51: Review Docker build and push configurations.

Review the configuration for building and pushing Docker images to ensure that it aligns with the project's deployment and versioning strategies. This includes checking the context, file paths, platforms, and the push settings.

.github/workflows/release-docker.yml (4)

7-10: Ensure the new environment variables are documented.

Please verify that the new environment variables (APP_NAME, DOCKER_FILE, DOCKER_PLATFORMS) are documented in the project's README or relevant documentation to ensure they are properly understood and utilized by other developers or in CI/CD pipelines.


26-36: Validate Docker metadata configuration.

Ensure that the Docker metadata configuration, including tags and labels, is correctly set up to reflect the intended Docker image properties. This is crucial for image versioning and management.


37-44: Check compatibility of Docker Buildx and QEMU setup.

Confirm that the Docker Buildx and QEMU setup actions (docker/[email protected] and docker/[email protected]) are compatible with the project's requirements and that they function correctly across all intended platforms, especially the newly added ARM64.


45-53: Review Docker build and push configurations.

Review the configuration for building and pushing Docker images to ensure that it aligns with the project's deployment and versioning strategies. This includes checking the context, file paths, platforms, and the push settings.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankit16-19
Copy link
Collaborator Author

ankit16-19 commented Apr 23, 2024

@nylonee hey man, I'm not sure why but docker login seems to be failing for these workflows.
It seems to be working with me for both docker/login-action v1 and v2.
for your REPO non of them seems to be working. Can you please check if you have configured your permission to work in some other way?

I'm happy to debug but it's limiting me to run workflows. If you allow me to run workflows, I might be able to get this working.

I tried to close/recreate PR's to try to run them, didn't work 😄

@nylonee
Copy link
Owner

nylonee commented Apr 23, 2024

Hey @ankit16-19

Great work on this PR!

I think the issue is due to the docker secrets being only available to contributors of this repo (which is a bit annoying, but I couldn't figure out how to change it, if you're tinkering with the docker setup perhaps you'd be able to find a good workaround later)

I've sent you an invite to be a collaborator, once you accept that you may need to close and re-open a PR again, but hopefully it resolves the issue!

@ankit16-19 ankit16-19 closed this Apr 23, 2024
@ankit16-19
Copy link
Collaborator Author

Thanks. @nylonee . Let me try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants