-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for ARM64 #135
Conversation
WalkthroughThe recent updates to the GitHub workflow files revolve around enhancing Docker workflows. These enhancements include the introduction of new environment variables, the restructuring of steps, and the addition of various actions such as Docker metadata, QEMU setup, Buildx setup, and the build/push processes for Docker images. Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Additional comments not posted (12)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@nylonee hey man, I'm not sure why but docker login seems to be failing for these workflows. I'm happy to debug but it's limiting me to run workflows. If you allow me to run workflows, I might be able to get this working. I tried to close/recreate PR's to try to run them, didn't work 😄 |
Hey @ankit16-19 Great work on this PR! I think the issue is due to the docker secrets being only available to contributors of this repo (which is a bit annoying, but I couldn't figure out how to change it, if you're tinkering with the docker setup perhaps you'd be able to find a good workaround later) I've sent you an invite to be a collaborator, once you accept that you may need to close and re-open a PR again, but hopefully it resolves the issue! |
Thanks. @nylonee . Let me try that. |
Description
Adding support for ARM64 releases.
Breaking changes:
Checklist
sbt scalafmtAll
Run (and optionallysbt scalafmtSbt
)Summary by CodeRabbit