Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random parameter to RSS URLs overcome server-side caching #183

Closed
wants to merge 1 commit into from

Conversation

tiredjohn
Copy link

@tiredjohn tiredjohn commented Aug 28, 2024

Description

Plex has added server-side caching to their watchlist RSS feeds, this change appends a parameter "r" to the RSS URL along with a random 10 character alphanumeric value to overcome this caching.

Summary by CodeRabbit

  • New Features
    • Enhanced watchlist fetching by adding a random query parameter to improve request uniqueness.
  • Bug Fixes
    • Improved handling of RSS feed requests, potentially optimizing server response and caching behavior.

Copy link

coderabbitai bot commented Aug 28, 2024

Walkthrough

The modification in the PlexUtils trait includes an update to the fetchWatchlistFromRss method. An additional query parameter, r, has been introduced in the URL construction, which is created using a random alphanumeric string of 10 characters. While the core logic of the method remains unchanged, this update may impact how the requests are processed by the server.

Changes

Files Change Summary
src/main/scala/plex/PlexUtils.scala Updated the fetchWatchlistFromRss method to include a random alphanumeric query parameter r in the URL.

Poem

In the fields where the bunnies play,
A change has hopped in, brightening the day.
With a random string added, oh what a delight,
Fetching watchlists now feels just right!
So let’s dance and twirl with glee,
For every request, unique as can be! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cbe01de and 5800717.

Files selected for processing (1)
  • src/main/scala/plex/PlexUtils.scala (1 hunks)
Additional comments not posted (1)
src/main/scala/plex/PlexUtils.scala (1)

24-24: Ensure proper URL construction with random parameter.

The addition of the random parameter r to the RSS URL is implemented correctly using Scala's Random.alphanumeric.take(10).mkString. This approach should effectively bypass server-side caching by making each URL unique. However, consider the following improvements:

  • Security and Performance Considerations: Ensure that the randomness and length of the parameter are sufficient to prevent potential security issues related to predictability and caching efficiency.
  • Code Clarity: While the current implementation is concise, adding a brief comment explaining the purpose of the r parameter could improve code maintainability.

The change is logical and aligns with the PR's objectives. However, consider the suggested improvements for enhanced security and clarity.

Copy link

@jmsprsns jmsprsns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@nylonee
Copy link
Owner

nylonee commented Oct 16, 2024

Heya, thanks for this! I wanted to make some minor changes but it looks like I can't edit your branch so I've made a new branch here: #190

(Sorry I've been overseas for a while, back now)

@nylonee nylonee closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants