Allow custom filename when adding an attachment #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loomchild
commented
Oct 16, 2024
| @@ -92,8 +92,8 @@ def self.handle_message_payload(request_body) | |||
| # Build the request to attach a file to a message/draft object. | |||
| # @param file_path [String] The path to the file to attach. | |||
| # @return [Hash] The request that will attach the file to the message/draft | |||
| def self.attach_file_request_builder(file_path) | |||
| filename = File.basename(file_path) | |||
| def self.attach_file_request_builder(file_path, filename = nil) | |||
There was a problem hiding this comment.
Alternatively, it could also be named parameter: filename: nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding an attachment to an email, the filename that will be sent is determined by the provided file path. This is problematic when using
Tempfilebecause part of the path will be random. I propose accepting an optionalfilenameparameter inFileUtils.attach_file_request_builder.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.