Fix: nodes without active installs are hidden on the map #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 94.03% 94.03% -0.01%
==========================================
Files 75 75
Lines 3087 3086 -1
==========================================
- Hits 2903 2902 -1
Misses 184 184 ☔ View full report in Codecov by Sentry. |
WillNilges
approved these changes
Sep 30, 2024
WillNilges
pushed a commit
that referenced
this pull request
Oct 12, 2024
* Fix: nodes without active installs are hidden on the map * Remove ALLOWED_INSTALL_STATUSES entirely
WillNilges
added a commit
that referenced
this pull request
Oct 24, 2024
* fix 500 on bldg * Store changed info and print something * fancy * Now I gotta update all these tests :( * This feels very brittle * That's maybe a little better. * Test cases * update tests * Add trust_me_bro * Add trust_me_bro to test data * format * set trust_me_bro * checkpoint * computers * Formatting? * Parsed City * Remove State + Zip warning State is a dropdown and Zip breaks if it's wrong. * Fix import crash (#598) * Make name dedupe logic case-insensitive & prefer longer names (#556) * Make name dedupe logic case-insensitive & prefer longer names * Fix uuid convention * Add django-simple-history (#599) * Add django-simple-history * Fix: crash on permissions object * Fix typo * Change ticket number to charfield (#562) * Change ticket number to charfield * Fix tests * Update src/meshapi/migrations/0031_alter_install_ticket_number.py Co-authored-by: Willard Nilges <[email protected]> * Update src/meshapi/models/install.py Co-authored-by: Willard Nilges <[email protected]> * Merge migration conflicts --------- Co-authored-by: Willard Nilges <[email protected]> * rename all instances of prod1 -> prod + docs cleanup (#618) * rolling restart stateful sets (#620) * only backup 'default' (#621) * Add new encrypted volume (#615) * use the new one (#623) * Complete volume swap (#616) * Add new encrypted volume * swap postgres to encrypted volume * cleanup old pv * Fix 500 on panorama building save (for real this time) (#622) * Fix: NYC addresses are sent to random New England towns (#604) * Fix: NYC addresses are sent to random new england towns * Add typo fix for "sreet" * Import fixes (#607) * Exclude placeholder devices from inactive node resurrection * Fix: Spreadsheet LOS import has `SpreadsheetLinkStatus.` before the status notes * Clean up node notes * Fix: nodes without active installs are hidden on the map (#606) * Fix: nodes without active installs are hidden on the map * Remove ALLOWED_INSTALL_STATUSES entirely * Fix: nodes is required to edit building object (#600) * Fix: exports get captured by captive nav and don't download (#601) * Add missing assert_ to called_once_with (#619) * Fix: crash due to link sheet format change (#626) * Fix: zip code validation only applies to non-NYC addresses (#629) * got it * Update submission format * get tests working * computers * lint * zip * black * Check that we say no to NJ properly: * move check * fix thingie * Add another test * Default to str when dumping json object * lint * lint * email * lint * insanity * email * Wild fucking guess, but this test should now create 3 members instead of 2 * fix git fuckery * Test nyc join form but nj zip --------- Co-authored-by: Andrew Dickinson <[email protected]> Co-authored-by: james-otten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter dates back all the way to before we had a node object, and the following code is all capable of handling the "only inactive installs" case. It's blocking the display of the nodes we fixed in #564 (like NN238 and NN525), so it seems we should remove it