Setup django project #53
Conversation
|
hmmm do we want to prevent people from signing up with duplicate emails and phone numbers? |
Good idea, that makes sense. Should we do it in another PR? I think what we have now will be fine for development testing purposes. |
WillNilges
force-pushed
the
willnilges/django
branch
from
63e76ff
to
17694c3
Compare
There was a problem hiding this comment.
Great work Willard. I left a lot of comments inline, but as a general note I'll say we don't have to resolve all of them right now. I'm happy to create separate GitHub issues to track this stuff, (especially the high-level comments) so that we can merge this PR quickly and unblock other dev work. Just wanted to leave them here so we don't loose track of them
We need to be careful however, we are inheriting a dataset that does not have a uniqueness constraint on those fields, so we can never assume it, even if we bar it going forward |
I was imagining this would happen as a function when a request comes in vs an actual database constraint. We could check if someone already has an active node. I imagine Brian, Daniel etc. will brake this rule though. |
|
This looks very good, seems to be organized far better than what we had before. |
|
Closes #51 |
Models and some serializers It functions Need to write the rest of the serializers and endpoints, figure out how to talk to postgres, and confirm that validation works the way I want it to. The rest of the serializers and endpoints™ This should be the basics. No guarantee of correctness. Need to check on validation and what have you, yada yada. Generics are cool Basic admin or naw authentication Fine tune permissions a lil bit? IDK if this is correct, but I think I'm starting to understand how auth works. I need to go to bed. Ops scaffolding More ops scaffolding A lot of this is going to have to change because I am going to bring in nginx Ops scaffolding 3: The epic conclusion I added an Nginx server so that we could serve static files and gave a best guess at configuring CSRF trusted origins. Update README.md Fun badges Remove boilerplate Andy Comments black? Make sure debug mode is OFF!!! Whoops missed a 'lint' Remove more boilerplate Andrew Comments Part 1
Andrew Comments 2/2 outer meshdb -> src Update Dockerfile Andrew was right Update .env.sample Update debug instructions Fix dockerfile and the user serializer
WillNilges
force-pushed
the
willnilges/django
branch
from
c778410
to
b92b5df
Compare
|
beeg squash |
No description provided.