Switch to pyproject.toml & add invoke.py system #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybaumgar
approved these changes
Sep 1, 2023
pyproject.toml
Outdated
|
|
||
|
|
||
| [tool.black] | ||
| line-length = 100 |
WillNilges
requested changes
Sep 1, 2023
Dockerfile
Outdated
Comment on lines
4
to
7
| COPY requirements.txt . | ||
| RUN pip install -r requirements.txt | ||
|
|
||
| # FIXME: This probably isn't the file structure we want. | ||
| COPY . . | ||
| RUN pip install . |
There was a problem hiding this comment.
The reason we copy the requirements.txt before copying the rest of the code is so that caching works properly :E
Andrew-Dickinson
force-pushed
the
pyproject-toml
branch
from
f5bfece
to
9338289
Compare
quoncc
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120
quoncc
added a commit
that referenced
this pull request
Sep 1, 2023
added security config initial implementation of flask-security intial implementation of flask-security removed old auth implementaiton removed secret keys restored balance to the universe Add example of unit testing (#37) Switch to pyproject.toml & add invoke.py system (#40) * Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120 Switch GH actions to run pyinvoke lint check black'd added flask-security envs changed email to agnostic entry added flask-security to dependencies add comment about csrf black
quoncc
added a commit
that referenced
this pull request
Sep 1, 2023
* black magic added security config initial implementation of flask-security intial implementation of flask-security removed old auth implementaiton removed secret keys restored balance to the universe Add example of unit testing (#37) Switch to pyproject.toml & add invoke.py system (#40) * Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120 Switch GH actions to run pyinvoke lint check black'd added flask-security envs changed email to agnostic entry added flask-security to dependencies add comment about csrf black * fixed version * flask-security-too requirement * added flaks-security addendum to readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of
requirements.txtin favor of the more modernpyproject.tomlfileI also added in some task helpers using pyinvoke. See the readme changes for more information.
I have also laid the groundwork for some additional linting via
flake8,isort, andmypy. However, these checks don't pass yet and so I will enable them via separate PRs to keep this one simple and so that we have a chance to discuss the merits of each one if needed