-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml & add invoke.py system #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one comment.
pyproject.toml
Outdated
|
||
|
||
[tool.black] | ||
line-length = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to 120
Dockerfile
Outdated
COPY requirements.txt . | ||
RUN pip install -r requirements.txt | ||
|
||
# FIXME: This probably isn't the file structure we want. | ||
COPY . . | ||
RUN pip install . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we copy the requirements.txt before copying the rest of the code is so that caching works properly :E
f5bfece
to
9338289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
* Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120
added security config initial implementation of flask-security intial implementation of flask-security removed old auth implementaiton removed secret keys restored balance to the universe Add example of unit testing (#37) Switch to pyproject.toml & add invoke.py system (#40) * Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120 Switch GH actions to run pyinvoke lint check black'd added flask-security envs changed email to agnostic entry added flask-security to dependencies add comment about csrf black
* black magic added security config initial implementation of flask-security intial implementation of flask-security removed old auth implementaiton removed secret keys restored balance to the universe Add example of unit testing (#37) Switch to pyproject.toml & add invoke.py system (#40) * Switch to pyproject.toml & add invoke.py system * Fix dependency caching in docker build * Set line length to 120 Switch GH actions to run pyinvoke lint check black'd added flask-security envs changed email to agnostic entry added flask-security to dependencies add comment about csrf black * fixed version * flask-security-too requirement * added flaks-security addendum to readme
This PR gets rid of
requirements.txt
in favor of the more modernpyproject.toml
fileI also added in some task helpers using pyinvoke. See the readme changes for more information.
I have also laid the groundwork for some additional linting via
flake8
,isort
, andmypy
. However, these checks don't pass yet and so I will enable them via separate PRs to keep this one simple and so that we have a chance to discuss the merits of each one if needed