Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: test is failing due to changed API response #378

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Andrew-Dickinson
Copy link
Member

The NYC address parsing API changed their response from Boulevard to Bl which broke one of our tests. More evidence that mocking would be sensible, but this fix will work for now

@Andrew-Dickinson Andrew-Dickinson mentioned this pull request Jun 1, 2024
Copy link
Collaborator

@james-otten james-otten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it

@Andrew-Dickinson Andrew-Dickinson merged commit bed2c43 into main Jun 1, 2024
7 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/fix-test branch July 6, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants