Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve some mypy findings #367

Merged
merged 2 commits into from
May 15, 2024
Merged

Resolve some mypy findings #367

merged 2 commits into from
May 15, 2024

Conversation

james-otten
Copy link
Collaborator

Related to #266

@Andrew-Dickinson
Copy link
Member

You probably know this, but Any is kind of a cheat which basically disables mypy for those variables. It's fine for scrappy stuff like support scripts, or when the types get stupid/gnarly, but we should try not to use it when it can be avoided

@james-otten james-otten merged commit 9a253ba into main May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Dickinson Andrew-Dickinson Andrew-Dickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-otten @Andrew-Dickinson