Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting fixes #272

Merged
merged 11 commits into from
Mar 31, 2024
Merged

Linting fixes #272

merged 11 commits into from
Mar 31, 2024

Conversation

james-otten
Copy link
Collaborator

Various fixes for tool reported style issues.

  1. Resolve all import ordering issues via isort
  2. Resolve all style issues via black
  3. Enable isort . --check in invoke lint
  4. Enable isort . in invoke format
  5. Resolve some style issues identified by flake8 (mostly unused imports)

@Andrew-Dickinson
Copy link
Member

Nice, this resolves much of #266!

Andrew-Dickinson
Andrew-Dickinson approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this!

WillNilges
WillNilges approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. We oughta add some more linting tools to our pipelines.

@Andrew-Dickinson
Copy link
Member

Note: this PR does add these tools to our pipelines, since they use pyinvoke and this PR updates the pyinvoke tasks

@WillNilges WillNilges merged commit 4ca9422 into nycmeshnet:main Mar 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Dickinson Andrew-Dickinson Andrew-Dickinson approved these changes

@WillNilges WillNilges WillNilges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-otten @Andrew-Dickinson @WillNilges