Skip to content

Commit

Permalink
Typing fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew-Dickinson committed Oct 8, 2024
1 parent 713a630 commit e66319b
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/meshapi/admin/models/device.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import os
from typing import Optional

from django import forms
from django.contrib import admin
from django.contrib.admin.utils import unquote
from django.contrib.postgres.search import SearchVector
from django.db.models import QuerySet
from django.http import HttpRequest
from django.http import HttpRequest, HttpResponse, HttpResponseRedirect
from django.shortcuts import redirect
from import_export.admin import ExportActionMixin, ImportExportMixin
from simple_history.admin import SimpleHistoryAdmin
Expand Down Expand Up @@ -91,7 +92,7 @@ def get_queryset(self, request: HttpRequest) -> QuerySet[Device]:

return queryset

def _get_subtype_redirect(self, request, object_id):
def _get_subtype_redirect(self, request: HttpRequest, object_id: str) -> Optional[HttpResponseRedirect]:
"""Create a redirect for an AP or sector device by its object ID (if such a subtype exists)"""
device = Device.objects.filter(pk=object_id).first()
if not device:
Expand All @@ -101,7 +102,9 @@ def _get_subtype_redirect(self, request, object_id):
target_url = get_admin_url(downclassed_model_obj, site_base_url=f"{request.scheme}://{request.get_host()}")
return redirect(target_url)

def _changeform_view(self, request, object_id, form_url, extra_context):
def _changeform_view(
self, request: HttpRequest, object_id: str, form_url: str, extra_context: dict
) -> HttpResponse:
if object_id and not self.get_object(request, unquote(object_id), None):
# If the built-in object lookup logic doesn't find this device,
# it's probably because it's excluded in get_queryset() above
Expand Down

0 comments on commit e66319b

Please sign in to comment.