Skip to content

Commit

Permalink
Import phone numbers from dupes when we don't already have one (#306)
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew-Dickinson authored Apr 2, 2024
1 parent e07acff commit a0a6fef
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/meshdb/utils/spreadsheet_import/parse_member.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,18 @@ def diff_new_member_against_existing(
)
diff_notes += f"\nDropped name change from install #{row_id}: {new_member.name}"

if existing_member.phone_number != new_member.phone_number and new_member.phone_number:
if (
existing_member.phone_number != new_member.phone_number
and new_member.phone_number
and existing_member.phone_number
):
add_dropped_edit(
DroppedModification(
list(install.install_number for install in existing_member.installs.all()),
row_id,
existing_member.primary_email_address,
"member.phone_number",
existing_member.phone_number if existing_member.phone_number else "",
existing_member.phone_number,
new_member.phone_number,
)
)
Expand Down Expand Up @@ -228,6 +232,9 @@ def nop(*args, **kwargs):
add_dropped_edit,
)

if formatted_phone_number and not existing_members[0].phone_number:
existing_members[0].phone_number = formatted_phone_number

# TODO: Don't forget to remove me if we remove the previous use of contact notes above
if row.contactNotes:
if not existing_members[0].notes:
Expand Down

0 comments on commit a0a6fef

Please sign in to comment.