Add django-simple-history (#599)

* Add django-simple-history

* Fix: crash on permissions object

* Fix typo

pyproject.toml

@@ -41,6 +41,7 @@ dependencies = [
     "six==1.16.0",
     "django-flags==5.0.*",
     "django-sql-explorer==5.2.*",
+    "django-simple-history==3.7.*",
 ]
 
 [project.optional-dependencies]

scripts/import_spreadsheet_dump.sh

@@ -2,8 +2,28 @@
 
 DOCKER_PG_COMMAND="docker exec -i meshdb-postgres-1 psql -U meshdb"
 DATA_DIR="./spreadsheet_data/"
-tables=("meshapi_link" "meshapi_accesspoint" "meshapi_sector" "meshapi_device" "meshapi_building_nodes" "meshapi_node" "meshapi_install" "meshapi_building" "meshapi_member")
-#tables=("meshapi_link" "meshapi_building_nodes"  "meshapi_sector" "meshapi_device" "meshapi_install" "meshapi_member"  "meshapi_building" "meshapi_node")
+tables=(
+"meshapi_los"
+"meshapi_link"
+"meshapi_accesspoint"
+"meshapi_sector"
+"meshapi_device"
+"meshapi_building_nodes"
+"meshapi_node"
+"meshapi_install"
+"meshapi_building"
+"meshapi_member"
+"meshapi_historicallos"
+"meshapi_historicallink"
+"meshapi_historicalaccesspoint"
+"meshapi_historicalsector"
+"meshapi_historicaldevice"
+"meshapi_historicalbuilding_nodes"
+"meshapi_historicalnode"
+"meshapi_historicalinstall"
+"meshapi_historicalbuilding"
+"meshapi_historicalmember"
+)
 set -ex
 
 # Make sure our files exist.

src/meshapi/admin/models/access_point.py

@@ -4,7 +4,8 @@
 from django.contrib.postgres.search import SearchVector
 from django.forms import Field, ModelForm
 from django.http import HttpRequest
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import AccessPoint
 from meshapi.widgets import AutoPopulateLocationWidget, DeviceIPAddressWidget, ExternalHyperlinkWidget
@@ -32,7 +33,7 @@ class Meta:
 
 
 @admin.register(AccessPoint)
-class AccessPointAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class AccessPointAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = AccessPointAdminForm
     search_fields = ["name__icontains", "@notes"]
     search_vector = SearchVector("name", weight="A") + SearchVector("notes", weight="D")

src/meshapi/admin/models/building.py

@@ -7,7 +7,8 @@
 from django.db.models import QuerySet
 from django.forms import ModelForm
 from django.http import HttpRequest
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Building
 from meshapi.widgets import AutoPopulateLocationWidget, PanoramaViewer
@@ -60,7 +61,7 @@ class Meta:
 
 
 @admin.register(Building)
-class BuildingAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class BuildingAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = BuildingAdminForm
     list_display = ["__str__", "street_address", "primary_node"]
     search_fields = [

src/meshapi/admin/models/device.py

@@ -5,7 +5,8 @@
 from django.contrib.postgres.search import SearchVector
 from django.db.models import QuerySet
 from django.http import HttpRequest
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Device
 from meshapi.widgets import ExternalHyperlinkWidget
@@ -30,7 +31,7 @@ class Meta:
 
 
 @admin.register(Device)
-class DeviceAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class DeviceAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = DeviceAdminForm
     search_fields = ["name__icontains", "@notes"]
     search_vector = SearchVector("name", weight="A") + SearchVector("notes", weight="D")

src/meshapi/admin/models/install.py

@@ -8,7 +8,8 @@
 from django.db.models import QuerySet
 from django.http import HttpRequest
 from import_export import resources
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Install
 from meshapi.widgets import ExternalHyperlinkWidget
@@ -43,7 +44,7 @@ class Meta:
 
 
 @admin.register(Install)
-class InstallAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class InstallAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = InstallAdminForm
     resource_classes = [InstallImportExportResource]
     list_filter = [

src/meshapi/admin/models/link.py

@@ -1,7 +1,8 @@
 from django import forms
 from django.contrib import admin
 from django.contrib.postgres.search import SearchVector
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Link
 
@@ -18,7 +19,7 @@ class Meta:
 
 
 @admin.register(Link)
-class LinkAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class LinkAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = LinkAdminForm
     search_fields = [
         "from_device__node__name__icontains",

src/meshapi/admin/models/los.py

@@ -6,7 +6,8 @@
 from django.contrib.postgres.search import SearchVector
 from django.forms import ModelForm
 from django.http import HttpRequest
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import LOS
 
@@ -20,7 +21,7 @@ class Meta:
 
 
 @admin.register(LOS)
-class LOSAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class LOSAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = LOSAdminForm
     search_fields = [
         "from_building__nodes__network_number__iexact",

src/meshapi/admin/models/member.py

@@ -1,7 +1,8 @@
 from django import forms
 from django.contrib import admin
 from django.contrib.postgres.search import SearchVector
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Member
 
@@ -22,7 +23,7 @@ class Meta:
 
 
 @admin.register(Member)
-class MemberAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class MemberAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = MemberAdminForm
     search_fields = [
         # Search by name

src/meshapi/admin/models/node.py

@@ -9,6 +9,7 @@
 from django.http import HttpRequest
 from import_export import resources
 from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Building, Node
 from meshapi.widgets import AutoPopulateLocationWidget
@@ -49,7 +50,7 @@ class Meta:
 
 
 @admin.register(Node)
-class NodeAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class NodeAdmin(RankedSearchMixin, ExportActionMixin, ImportExportModelAdmin, SimpleHistoryAdmin):
     form = NodeAdminForm
     resource_classes = [NodeImportExportResource]
     search_fields = [

src/meshapi/admin/models/sector.py

@@ -1,6 +1,7 @@
 from django.contrib import admin
 from django.contrib.postgres.search import SearchVector
-from import_export.admin import ExportActionMixin, ImportExportModelAdmin
+from import_export.admin import ExportActionMixin, ImportExportMixin
+from simple_history.admin import SimpleHistoryAdmin
 
 from meshapi.models import Sector
 from meshapi.widgets import ExternalHyperlinkWidget
@@ -22,7 +23,7 @@ class Meta:
 
 
 @admin.register(Sector)
-class SectorAdmin(RankedSearchMixin, ImportExportModelAdmin, ExportActionMixin):
+class SectorAdmin(RankedSearchMixin, ImportExportMixin, ExportActionMixin, SimpleHistoryAdmin):
     form = SectorAdminForm
     search_fields = ["name__icontains", "@notes"]
     search_vector = SearchVector("name", weight="A") + SearchVector("notes", weight="D")

src/meshapi/management/commands/create_groups.py

@@ -35,7 +35,8 @@ def create_base_groups(self) -> None:
 
         for p in all_permissions:
             code = p.codename
-            act, obj = code.split("_")
+
+            act, obj = code.split("_", maxsplit=1)
 
             # read_only
             if act == "view" and obj in models: