Skip to content

Commit

Permalink
Remove unused /user endpoints to reduce confusion (#204)
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrew-Dickinson authored Feb 19, 2024
1 parent 5066486 commit 32b55b8
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 20 deletions.
6 changes: 0 additions & 6 deletions src/meshapi/serializers/model_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@
from meshapi.permissions import check_has_model_view_permission


class UserSerializer(serializers.ModelSerializer):
class Meta:
model = User
fields = "__all__"


class RecursiveSerializer(serializers.ModelSerializer):
"""
A serializer which follows foreign-key relationships when serializing, taking care to avoid
Expand Down
2 changes: 0 additions & 2 deletions src/meshapi/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
urlpatterns = [
path("", views.api_root),
path("auth/", include("rest_framework.urls")),
path("users/", views.UserList.as_view(), name="meshapi-v1-user-list"),
path("users/<int:pk>/", views.UserDetail.as_view(), name="meshapi-v1-user-detail"),
path("buildings/", views.BuildingList.as_view(), name="meshapi-v1-building-list"),
path("buildings/<int:pk>/", views.BuildingDetail.as_view(), name="meshapi-v1-building-detail"),
path("members/", views.MemberList.as_view(), name="meshapi-v1-member-list"),
Expand Down
11 changes: 0 additions & 11 deletions src/meshapi/views/model_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
LinkSerializer,
MemberSerializer,
SectorSerializer,
UserSerializer,
)


Expand All @@ -22,16 +21,6 @@ def api_root(request, format=None):
return Response("We're meshin'.")


class UserList(generics.ListAPIView):
queryset = User.objects.all()
serializer_class = UserSerializer


class UserDetail(generics.RetrieveAPIView):
queryset = User.objects.all()
serializer_class = UserSerializer


class BuildingList(generics.ListCreateAPIView):
queryset = Building.objects.all()
serializer_class = BuildingSerializer
Expand Down
2 changes: 1 addition & 1 deletion src/meshdb/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
2. Add a URL to urlpatterns: path('blog/', include('blog.urls'))
"""
from django.contrib import admin
from django.urls import path, include
from django.urls import include, path

urlpatterns = [
path("admin/", admin.site.urls),
Expand Down

0 comments on commit 32b55b8

Please sign in to comment.