Chupa master #6
Open
Chupa master #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pawn and king classes
add queen and knight class attributes
Dora bishop rook
Dbd development
…t_display_board Merged display method into code
Chupa master deselection
Chupa grant to chupa master for final pull request
| def initialize(location, color = "white") | ||
| @location = location | ||
| @color = color | ||
| @color == "white" ? @icon = "♝" : @icon = '♗' |
There was a problem hiding this comment.
@icon = (@color == "white" ? "♝" : '♗')
|
ILUVU @dieselroar @amihalopoulos @Doralyp @dmilburn @grantziolkowski Great work everyone! A lot of commits here, shows great effort. I really liked the use of small helper methods. Glad to see test cases here too. Organizationally this looked pretty good, aside from some left over commented code. Judicious use of commenting on the methods though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stevecass @zencephalon @dieselroar @amihalopoulos
Grant Charles and Alexei submitting weekend work. Lots of work here, but the checkmate method is not 100% flushed out and not everything is refactored.