Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning to make comments #48

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

foxdoubt
Copy link
Contributor

Hey @suprfrye and @bkmorimoto !

I'm starting to re-familiarize myself with the LineCook codebase because I'm going to start interviewing again soon!! (Codecademy contract # 2 ends in Late January).

I checked out a branch and plan to annotate every line of the JS and Ruby codebase so I feel confident talking about LineCook. Would you peeps mind reviewing my comments from time to time to make sure they're accurate?

DON'T MERGE THIS PR!! KEEP OPEN.

@suprfrye
Copy link
Contributor

Dan!

I'd love to! Hope I can help. Good luck with interviewing!

Tara

On Dec 22, 2015, at 9:41 PM, Dan Asselin [email protected] wrote:

Hey @suprfrye and @bkmorimoto !

I'm starting to re-familiarize myself with the LineCook codebase because I'm going to start interviewing again soon!! (Codecademy contract # 2 ends in Late January).

I checked out a branch and plan to annotate every line of the JS and Ruby codebase so I feel confident talking about LineCook. Would you peeps mind reviewing my comments from time to time to make sure they're accurate?

DON'T MERGE THIS PR!!

You can view, comment on, or merge this pull request online at:

#48

Commit Summary

Update README.md
Create tips-on-testing.md
Update README description
Update README description Pt.2
Add link to video demo
Annotate app.js bigOvenRecipeJSON function
File Changes

M README.md (79)
A tips-on-testing.md (42)
M workshop/www/js/app.js (18)
Patch Links:

https://github.com/nyc-rock-doves-2015/line-cook/pull/48.patch
https://github.com/nyc-rock-doves-2015/line-cook/pull/48.diff

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants