Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime.Runtime to hold config, DB and S3 #104

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add runtime.Runtime to hold config, DB and S3 #104

merged 1 commit into from
Jul 26, 2024

Conversation

rowanseymour
Copy link
Member

Like in mailroom

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 83.11688% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.34%. Comparing base (1b82d85) to head (58cc7b8).

Files Patch % Lines
cmd/rp-archiver/main.go 0.00% 10 Missing ⚠️
archives/runs.go 77.77% 1 Missing and 1 partial ⚠️
archives/messages.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   63.40%   63.34%   -0.07%     
==========================================
  Files           7        7              
  Lines        1003     1004       +1     
==========================================
  Hits          636      636              
- Misses        262      263       +1     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 8f1d826 into main Jul 26, 2024
6 of 7 checks passed
@rowanseymour rowanseymour deleted the runtime branch July 26, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant